Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 32191

Summary: pd-0.37 doesn't build
Product: Gentoo Linux Reporter: Kasper Souren <Kasper.Souren>
Component: New packagesAssignee: Gentoo Sound Team <sound>
Status: RESOLVED DUPLICATE    
Severity: normal CC: brandy
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: http://www.pure-data.org
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: proposed pd-0.37.0 patch

Description Kasper Souren 2003-10-28 07:08:24 UTC
pd-0.37 doesn't build:

gcc -DPD -DUNIX  -Wall -W -Wstrict-prototypes -Werror -Wno-unused -Wno-parentheses -Wno-switch -g -DDL_OPEN -DPA_USE_OSS -DPA_LITTLE_ENDIAN              -DUSEAPI_OSS         -I../portaudio/pa_common         -I../portaudio/pablio -I../portaudio/portmidi-macosx -Werror -DUSEAPI_JACK -DINSTALL_PREFIX=\"/usr\" -I. -c -o ../obj/s_audio_jack.o s_audio_jack.c
cc1: warnings being treated as errors
s_audio_jack.c: In function `srate':
s_audio_jack.c:72: warning: long int format, jack_nframes_t arg (arg 2)
make: *** [s_audio_jack.o] Error 1
Comment 1 Brandy Westcott (RETIRED) gentoo-dev 2003-10-28 16:21:53 UTC
This bug is the same as reported in bug #28007. Thankfully it can be
resolved in exactly the same way.
Comment 2 Brandy Westcott (RETIRED) gentoo-dev 2003-10-28 16:34:05 UTC
Created attachment 19908 [details, diff]
proposed pd-0.37.0 patch

This patch will allow pd-0.37.0 to compile when libjack.so is present
(which is provided by media-sound/jack-audio-connection-kit.)

Note. The pd compile will still fail when using gcc-3.3.x due to shadow
declarations:


cc -g -DPD -O2 -funroll-loops -fomit-frame-pointer -Wall -W -Wshadow
-Wstrict-prototypes -Werror -Wno-unused -Wno-parentheses -Wno-switch
-I../../src -o vexp.pd_linux_o -c vexp.c
vexp.c:81: warning: declaration of `exp' shadows a global declaration
<built-in>:0: warning: shadowed declaration is here
.....
vexp.c:1555: warning: declaration of `exp' shadows a global declaration
<built-in>:0: warning: shadowed declaration is here
make[1]: *** [vexp.pd_linux_o] Error 1
make[1]: Leaving directory
`/var/tmp/portage/pd-0.37.0/work/pd-0.37-0/extra/expr~'
make: *** [externs] Error 2
make: *** Waiting for unfinished jobs....

!!! ERROR: media-sound/pd-0.37.0 failed.
!!! Function src_compile, Line 41, Exitcode 2
!!! parallel make failed


These are caused by the inclusion of '-Werror' in extra/expr~/makefile.
A little sed magic is all that's needed to take this out:

	sed -i -e "s: -Werror::" ${S}/extra/expr~/makefile
Comment 3 Jonathan Kraut 2003-11-30 10:13:23 UTC
On Miller's site there is pd-0.37-1test1, which compiles fine for me (using gcc-3.2.3).  Perhaps a bump is in order?
Comment 4 Brian Harring (RETIRED) gentoo-dev 2004-02-04 16:12:58 UTC
Jonathan- I ran into this myself while doing some work on pd.  Long story short, it's a minor patch to fix it.  That said, I don't use the software, so I need somebody to test it...

Wanna be my guinnea pig?  heh.  Shouldn't be any issue (really a minor move w/in the src to make it compile), but I'd like to verify it.
Comment 5 Brian Harring (RETIRED) gentoo-dev 2004-02-06 12:26:54 UTC
Marking this bug as a duplicate of 39134, although the patch above solves the issue against jack-audio-connection-kit 0.80; the only reason I'm going for 39134 is the fix was pretty much lifted out of the current developmental version (along w/ a function rename that in it's normal state bugs me) :)
Feel free to overrule, functionally they're the same.

*** This bug has been marked as a duplicate of 39134 ***