Bug 319901

Summary:	kde-base/ksplash-4.3.5 won't compile with libpng-1.4.2: png.h has changed
Product:	Gentoo Linux	Reporter:	Howard B. Golden <howard_b_golden>
Component:	[OLD] KDE	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	tetromino
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	305095

Description Howard B. Golden 2010-05-15 23:57:29 UTC

After upgrading to libpng-1.4.2, module ksplash/qpngio.cpp won't compile because the 'trans' and 'trans_values' elements are no longer in png_info_struct, which is defined in /usr/include/png.h.

This is also the cause of bug 319487. The patch provided by Alexandre Rostovtsev should work either as is or with minor changes.

Respectful suggestion: Please don't close bugs like 319487 without considering that the problem might also apply to later versions which are still supported. Thanks.

Error messages during compile follow (deprecation warnings have been removed to save space):

[ 12%] [ 16%] Building CXX object ksplash/ksplashx/CMakeFiles/ksplashx.dir/qpngio.o
Built target ksplashsimple                    
[ 16%] Scanning dependencies of target ksplashx_scale
/var/tmp/paludis/kde-base-ksplash-4.3.5/work/ksplash-4.3.5/ksplash/ksplashx/qpngio.cpp: In function ‘void setup_qt(QImage&, png_struct*, png_info*, float)’:
...
/var/tmp/paludis/kde-base-ksplash-4.3.5/work/ksplash-4.3.5/ksplash/ksplashx/qpngio.cpp:154: error: ‘struct png_info_struct’ has no member named ‘trans_values’  
...
/var/tmp/paludis/kde-base-ksplash-4.3.5/work/ksplash-4.3.5/ksplash/ksplashx/qpngio.cpp:182: error: ‘struct png_info_struct’ has no member named ‘trans’
...

Comment 1 Samuli Suominen (RETIRED) gentoo-dev

2010-05-16 06:24:59 UTC

This should be fixed, considering libpng-1.4.x will likely hit stable before kde-4.4.x.

Same error is fixed in e.g. 

media-gfx/povray/files/povray-3.6.1-libpng14.patch
http://repos.archlinux.org/wsvn/packages/libgdiplus/trunk/gdiplus-png14.patch

But also likely in KDE's upstream considering I don't remember hitting this problem with 4.4.x.

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2010-05-16 12:13:50 UTC

+  16 May 2010; Samuli Suominen <ssuominen@gentoo.org> ksplash-4.3.5.ebuild,
+  +files/ksplash-4.3.5-libpng14.patch:
+  Fix building with libpng14 wrt #319901 by Howard B. Golden.

and yet again we get to thank archlinux:

http://www.mail-archive.com/arch-commits@archlinux.org/msg06718.html