| Summary: | kde-base/kopete-4.4.3: USE winpopup needs net-fs/samba[server,smbclient] as RDEPEND | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Nikoli <nikoli> |
| Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 313999 | ||
|
Description
Nikoli
2010-05-10 16:46:00 UTC
kopete has no build or run-time dependency on samba. I suspect it just uses a samba binary when trying to send messages through winpopup. In that case, we'll add a pkg_postinst warning, but it doesn't justify a dep. You are wrong, unpack kdenetwork-4.4.4.tar.bz2 and do 'grep -Ri -e samba -e smb kopete/protocols/winpopup/'. Without samba kopete does not work with winpopup protocol. Not only one feature of protocol, but all. Why you think is not enough for RDEPEND, what is enough then? pkg_postinst should tell that winpopup needs running samba server. You can use the following to check run-time dependencies of an installed package. Running that on kopete built with winpopup doesn't list samba.
qlist -vo ${1} | xargs scanelf -L -n -q -F '%n #F' | tr , ' ' | xargs qfile -C | sort -u
So as there's no linking to samba, the only other option is for kopete to call a binary directly - a bit like krdc and rdesktop. You can confirm this by grepping the sources for smb.
In any case, I've now added the samba run-time dependency for the winpopup use flag - but the reason it wasn't added or identified before is that the CMakeLists.txt have no mention of samba.
|
