Summary: | app-office/openoffice fails to build with gcc 4.5 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
Component: | New packages | Assignee: | Gentoo Office Team <office> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anthoine.bourgeois, Arsen.Shnurkov, b.brachaczek, chainsaw, cruzki123, kevin.bowling |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 296658 | ||
Attachments: |
Build log
patch from upstream bug patch from upstream bug, adjusted to fit to ooo-build |
Description
Diego Elio Pettenò (RETIRED)
2010-04-26 01:41:28 UTC
Created attachment 229165 [details]
Build log
There's already upstream bug for that: http://www.openoffice.org/issues/show_bug.cgi?id=109853. They have a patch, attaching it. Created attachment 229213 [details, diff]
patch from upstream bug
Would be nice if someone could test this, I really don't want to change my local toolchain just for this ;-) @Bartosz: This is only the first patch, upstream bug says that a second one is necessary (and attached there) (In reply to comment #4) > @Bartosz: This is only the first patch, upstream bug says that a second one is > necessary (and attached there) > The second patch was a workaround for a bug in gcc prerelease, and this bug is fixed in 4.5.0, so I assume it isn't needed anymore. Anyways, needs to be tested. The bug #317691 seems to be a duplicate of this one. *** Bug 317691 has been marked as a duplicate of this bug. *** (In reply to comment #5) > > The second patch was a workaround for a bug in gcc prerelease, and this bug is > fixed in 4.5.0, so I assume it isn't needed anymore. Anyways, needs to be > tested. The first patch is enough. I patched it by hand and then used ebuild oo.ebuild {compile,install,qmerge} but I have no idea how to make this in paludis ??? The file to be patched gets created during the compile ???? Created attachment 230669 [details, diff]
patch from upstream bug, adjusted to fit to ooo-build
Try forcing portage/paludis to apply the patch I've just submitted. Should work. (Haven't had time yet to check this). Suka, as the sole remaining openoffice maintainer I'm looking to you to apply this. I hereby register my intention to commit this patch in 7 days, unless I see a complaint from you in this bug report or you beat me to it. (In reply to comment #9) > Created an attachment (id=230669) [details] > patch from upstream bug, adjusted to fit to ooo-build > This is really not necessary (and wrong). Just copy the upstream patch to "${S}/patches/hotfixes" (see the ebuild for reference how we usually deal with such fixes) This is fixed now, thanks for the patch and comments. Closing. (In reply to comment #13) > This is fixed now, thanks for the patch and comments. Closing. > I see the file in my portage tree but don't think it is getting applied: In file included from ../../inc/uno/environment.hxx:37:0, from /var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/cppu/source/threadpool/current.cxx:38: ../../inc/uno/lbnames.h:70:2: error: #error "Supported gcc majors are 2 , 3 and 4 <= 4.4. Unsupported gcc major version." dmake: Error code 1, while making '../../unxlngx6.pro/slo/current.obj' 1 module(s): cppu need(s) to be rebuilt (In reply to comment #14) > (In reply to comment #13) > > This is fixed now, thanks for the patch and comments. Closing. > I see the file in my portage tree but don't think it is getting applied: According to the README in patches/hotfixes/README, the file needs to be suffixed .diff not as it is currently gcc45-buildfix.patch: | All patches in this directory are automatically applied in alphabetical order. | They are applied after the "regular" patches mentioned in the apply file. | Only files with the .diff suffix are processed. (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > This is fixed now, thanks for the patch and comments. Closing. > > I see the file in my portage tree but don't think it is getting applied: > > According to the README in patches/hotfixes/README, the file needs to be > suffixed .diff not as it is currently gcc45-buildfix.patch: Hmmm, weird, I actually thought I checked for the file being applied... Anyway I've renamed it now, hope that helps (In reply to comment #16) > > Hmmm, weird, I actually thought I checked for the file being applied... Anyway > I've renamed it now, hope that helps > Now it works with paludis, too - thanks |