| Summary: | www-apps/curator: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | Gentoo Web Application Packages Maintainers <web-apps> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fauli, idella4 |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 308257 | ||
| Attachments: |
ebuilds patch
revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch redone patch |
||
Created attachment 292363 [details]
ebuilds patch
Tiny package, tested on both 2 && 3, ALL OK
Usual bumP EAPI 3.
$ curator --help
File "/usr/bin/curator", line 279
print "Cache filename:", self.cachefn
^
SyntaxError: invalid syntax
Created attachment 293007 [details, diff]
revised ebuild patch
(In reply to comment #3) The changes introduced in this patch are correct, but they don't help in fixing problem mentioned in comment #2. Created attachment 293329 [details, diff]
revised ebuild patch
(In reply to comment #5) Use python_convert_shebangs(). Created attachment 293669 [details, diff]
revised ebuild patch
(In reply to comment #7) python_convert_shebangs() requires arguments. Created attachment 293775 [details, diff]
revised ebuild patch
how did I leave that out, sorry.
(In reply to comment #9) Changes for curator-2.1.ebuild are correct. python_convert_shebangs() is still incorrectly called in curator-2.0.ebuild. Please create patches only for the newest ebuild in each slot. Created attachment 293807 [details, diff]
revised ebuild patch
right, reduced to the one ebuild, doing two or more it seems wasn't helping
(In reply to comment #11) This patch changes curator-2.0.ebuild instead of curator-2.1.ebuild. Created attachment 293973 [details, diff]
revised ebuild patch
(In reply to comment #13) This patch doesn't apply cleanly. Created attachment 293989 [details, diff]
redone patch
this had better take
# mv curator-2.1.ebuild-copy curator-2.1.ebuild
# patch < /home/idella/patches/curator.patch
patching file curator-2.1.ebuild
'python_set_active_version 2' should be called before 'python_pkg_setup'. Fixed |
- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation [1] to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation [1]. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation [1]. - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml