Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 316965

Summary: sys-process/audit: Verify and potentially improve Python-related code
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever>
Component: Current packagesAssignee: Robin Johnson <robbat2>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 308257    
Attachments: audit-1.7.4-python.patch
audit-1.7.17-python.patch
Patch for ebuilds
Patch for old ebuilds
audit-2.0.5.ebuild.patch

Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-24 18:27:20 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 21:13:29 UTC
Created attachment 250155 [details, diff]
audit-1.7.4-python.patch
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 21:14:02 UTC
Created attachment 250159 [details, diff]
audit-1.7.17-python.patch
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 21:16:09 UTC
Created attachment 250161 [details, diff]
Patch for ebuilds
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 21:21:03 UTC
Created attachment 250171 [details, diff]
Patch for old ebuilds

This patch fixes calls to python_mod_optimize() and python_mod_cleanup() in old ebuilds.
Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-10 21:21:46 UTC
I will commit these patches, if you don't object in 1 week.
Comment 6 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-10-11 01:09:59 UTC
+1 on commit
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-10-15 21:16:11 UTC
Fixed.
Comment 8 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-02-07 21:27:30 UTC
Created attachment 261757 [details, diff]
audit-2.0.5.ebuild.patch

This patch adds support for installation of Python bindings for multiple Python ABIs.
Comment 9 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-02-07 21:39:46 UTC
Comment on attachment 261757 [details, diff]
audit-2.0.5.ebuild.patch

Patch committed.