Summary: | Version bump: sys-libs/zlib-1.2.5 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Samuli Suominen (RETIRED) <ssuominen> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | alon.barlev, the_paya |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 310209, 311241 | ||
Attachments: | zlib-1.2.5.ebuild.diff |
Description
Samuli Suominen (RETIRED)
2010-04-20 11:41:57 UTC
hopefully this is more stable than 1.2.4 ... Hello Vapier, 1. zlib-1.2.4-visibility-support.patch is not required, look zutil.h::ZLIB_INTERNAL 2. I don't understand why zlib-1.2.3-mingw-implib.patch is required... 3. Consider submitting the sed stuff to upstream? Created attachment 228547 [details, diff]
zlib-1.2.5.ebuild.diff
Fixups...
When do we have mingw fixups and build in core packages at tree?
use bug 310307 for mingw updates i gave up trying to get zlib to take fixes a while ago. submitting things via e-mail went unanswered. ive dropped the visibility stuff, thanks http://sources.gentoo.org/sys-libs/zlib/zlib-1.2.5.ebuild?r1=1.1&r2=1.2 Mind if I change: - sed -i 's|\<test "`\([^"]*\) 2>&1`" = ""|\1 2>/dev/null|' configure || die + sed -e 's|\<test "`\([^"]*\) 2>&1`" = ""|\1 2>/dev/null|' \ + -e 's:\*BSD:\*BSD | \*bsd\*:' -i configure || die on the ebuild? The script goes for $uname=$CHOST if $CHOST is set, and then the case $uname for LDSHARED variable compares against BSD in all caps. BSD CHOST have bsd in lowercase. This ends up leaving libz.so without a SONAME from the default case for $uname. (In reply to comment #5) > The script goes for $uname=$CHOST if $CHOST is set, and then the case $uname > for LDSHARED variable compares against BSD in all caps. BSD CHOST have bsd in > lowercase. > This ends up leaving libz.so without a SONAME from the default case for $uname. > Better modify the case: -Linux* | linux* | GNU | GNU/* | *BSD | DragonFly) LDSHARED=${LDSHARED-"$cc -shared -Wl,-soname,libz.so.1,--version-script,zlib.map"} ;; +Linux* | linux* | GNU | GNU/* | *BSD | *bsd | DragonFly) LDSHARED=${LDSHARED-"$cc --shared -Wl,-soname,libz.so.1,--version-script,zlib.map"} ;; You mean, as another patch to the code? That's what the sed does, except it's *bsd*, full G/FBSD CHOST is "i686-gentoo-freebsd8". (In reply to comment #7) > You mean, as another patch to the code? > That's what the sed does, except it's *bsd*, full G/FBSD CHOST is > "i686-gentoo-freebsd8". > Yes... So be it *bsd*... this bug is closed. new issues -> new bugs. |