| Summary: | net-misc/wicd: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | Thomas Kahle (RETIRED) <tomka> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | esigra |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 308257 | ||
Index: wicd-1.7.0.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/net-misc/wicd/wicd-1.7.0.ebuild,v retrieving revision 1.7 diff -u -B -r1.7 wicd-1.7.0.ebuild --- wicd-1.7.0.ebuild 23 May 2010 19:26:04 -0000 1.7 +++ wicd-1.7.0.ebuild 7 Nov 2010 17:14:22 -0000 @@ -4,7 +4,7 @@ EAPI=2 -inherit eutils distutils +inherit eutils distutils python DESCRIPTION="A lightweight wired and wireless network manager for Linux" HOMEPAGE="http://wicd.sourceforge.net/" @@ -45,7 +45,11 @@ libnotify? ( dev-python/notify-python ) ncurses? ( >=dev-python/urwid-0.9.9.1 ) pm-utils? ( >=sys-power/pm-utils-1.1.1 ) - " + =dev-lang/python-2*" + +pkg_setup() { + python_set_active_version 2 +} src_compile() { local myconf python-3 is not supported. (In reply to comment #0) > - If this package can be used as a library and installs Python modules > (*.so or *.py) into site-packages directories, then consider supporting > installation for multiple Python versions. > Please read section "Types of packages" in documentation [1] to decide > if this package can support installation for multiple Python versions. > > - Ensure that the ebuilds do not use deprecated functions or variables. > > - Please check if Python 3 is supported by this package. You can temporarily > set Python 3 as main active version of Python to properly test if this > package supports Python 3. > > - If this package does not support Python 3: > - Specify dependency on Python 2. > You can use PYTHON_DEPEND helper variable, which should be set before > inheriting of python eclass. > Please read section "Specification of dependency on Python" in > documentation [1]. > > - If this package cannot support installation for multiple versions of > Python, then set active version of Python using > python_set_active_version(). > > - Ensure that shebangs in installed scripts specify correct version of > Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you > can use python_convert_shebangs() to convert shebangs. > (Wrapper scripts generated by python_generate_wrapper_scripts() do not > require any changes.) > Please read section "Shebangs in installed scripts" in documentation [1]. > > - To ensure that changes applied to the ebuilds are sufficient, please > temporarily set Python 3 as main active version of Python and test if > this package can be properly installed and if it works at run time. > > Please see documentation [1] for more details. > [1] http://www.gentoo.org/proj/en/Python/developersguide.xml > I did not include the shebang update this will be required as well tho. assigning to new maintainer. +*wicd-1.7.1_beta2-r1 (21 Dec 2010) +*wicd-1.7.0-r1 (21 Dec 2010) + + 21 Dec 2010; Justin Lecher <jlec@gentoo.org> +wicd-1.7.0-r1.ebuild, + +wicd-1.7.1_beta2-r1.ebuild: + Verify and potentially improve Python-related code, #315847 + |
- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation [1] to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation [1]. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation [1]. - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml