Summary: | ebuild script: Unicode unequal comparison failed to convert both arguments to Unicode | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Michał Górny <mgorny> |
Component: | Core | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | esigra |
Priority: | High | Keywords: | InVCS |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 335925 | ||
Attachments: |
The proof-of-concept patch
Encode mycwd back to byte format Alternative approach patch (converting PWD to unicode format) |
Description
Michał Górny
2010-04-17 10:42:47 UTC
Created attachment 228113 [details, diff]
The proof-of-concept patch
Created attachment 228145 [details, diff]
Encode mycwd back to byte format
This patch performs the reverse of what portage's unicode module wrapper does, thus making the 'mycwd' suitable for comparison with os.environ['PWD'].
Created attachment 228147 [details, diff]
Alternative approach patch (converting PWD to unicode format)
And here's a patch offering the reverse approach to the issue. It converts the string obtained from os.environ['PWD'] to unicode like os.environ was unicode-wrapped too. This way we avoid converting mycwd forth and back.
Thanks, this is fixed in git: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=aab8d3dca843e07866755fc821b9bc9d5004bde5 This is in 2.2_rc68, but I'll leave this bug open until it's in an unmasked version. This is fixed in 2.1.9. |