Bug 315115 – net-im/pyicq-t: Verify and potentially improve Python-related code

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-04-13 20:58:48 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Maurice van der Pot (RETIRED) 2010-08-17 18:07:42 UTC]

I've retired as a gentoo dev. Reassigning to herd.

[Comment 2 Dennis Schridde 2011-05-26 22:18:26 UTC]

net-im/pyicq-t-0.8.1.5 requires PYTHON_DEPEND=2, otherwise errors occur:
--
# /etc/init.d/pyicq-t start
 * Starting ICQ Jabber Transport ...
Traceback (most recent call last):
  File "/usr/lib/python3.2/site-packages/pyicq-t/pyicq-t.py", line 11, in <module>
    import main
  File "/usr/lib/python3.2/site-packages/pyicq-t/src/main.py", line 15
    print selectWarning
                      ^
SyntaxError: invalid syntax
 * start-stop-daemon: failed to start `/usr/bin/python'                                                                                    [ !! ]
 * ERROR: pyicq-t failed to start

[Comment 3 Ian Delaney (RETIRED) 2011-11-27 18:55:20 UTC]

Created attachment 293963 [details, diff]
ebuild patch

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-27 21:38:42 UTC]

(In reply to comment #3)

pkg_setup() {
	python_set_active_version 2
	python_pkg_setup
}

${FILESDIR}/pyicq-t-0.8-initd should be fixed to not explicitly call /usr/bin/python.

"${ED}$(python_get_sitedir)/pyicq-t" should be executable.

Shebangs in scripts should be fixed.

[Comment 5 Ian Delaney (RETIRED) 2011-11-28 04:04:26 UTC]

Created attachment 294025 [details, diff]
revised ebuild patch

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-28 19:10:52 UTC]

(In reply to comment #5)

It's better to directly change the file in ${FILESDIR}.

python_convert_shebangs ${PYTHON_ABI} "${ED}$(python_get_sitedir)/${PN}/pyicq-t.py"

[Comment 7 Ian Delaney (RETIRED) 2011-11-29 07:32:36 UTC]

Created attachment 294129 [details, diff]
revised ebuild patch

[Comment 8 Hanno Böck 2013-03-18 15:54:18 UTC]

idella4: your patch contained some problems, i.e. inspath-dosed was removed and thus init-script didn't work any more. I've hopefully fixed everything and bumped pyicq-t.