|Summary:||net-dialup/freeradius: Verify and potentially improve Python-related code|
|Product:||Gentoo Linux||Reporter:||Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever>|
|Component:||[OLD] Server||Assignee:||Gentoo Dialup Developers <net-dialup>|
|Package list:||Runtime testing required:||---|
|Bug Depends on:|
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-04-13 20:49:31 UTC
- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation  to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation . - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation . - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation  for more details.  http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Ian Delaney (RETIRED) 2011-11-28 11:35:26 UTC
Created attachment 294047 [details, diff] ebuild patch I can't see that it has runtime deps on python other than thru linked libs. No .py files in the qlist a side issue to this. >>> * QA Notice: Package has poor programming practices which may compile >>> * fine but exhibit random runtime failures. >>> * rlm_ldap.c:2394:2: warning: implicit declaration of function "ldap_int_tls_config' >>> * QA Notice: Package has poor programming practices which may compile >>> * fine but exhibit random runtime failures. >>> * /usr/include/bits/stdio2.h:65:3: warning: call to __builtin___snprintf_chk will always overflow destination buffer Only 3 changes made.
Comment 2 Diego Elio Pettenò (RETIRED) 2012-09-30 07:09:11 UTC
Should be okay in 2.2.0.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2012-09-30 18:30:20 UTC
Files in src/modules/rlm_python directory are incompatible with Python 3.
Comment 4 Mike Gilbert 2012-09-30 18:31:48 UTC
Re-opening per Arfrever's request.
Comment 5 Jeroen Roovers (RETIRED) 2014-05-03 15:58:34 UTC
Something similar was done for 2.2.0.