Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 314861

Summary: app-misc/gcal-3.5.1 version bump
Product: Gentoo Linux Reporter: Jeroen Roovers (RETIRED) <jer>
Component: Current packagesAssignee: Ulrich Müller <ulm>
Status: RESOLVED UPSTREAM    
Severity: enhancement CC: gscrivano, shell-tools
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Ebuild patch

Description Jeroen Roovers (RETIRED) gentoo-dev 2010-04-12 19:06:08 UTC
Yes, it's been ten years in the making! Probably a GPL-3 update and some old patches.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-04-12 19:07:41 UTC
NEWS file for `gcal'.

User-visible changes.

Major changes in release 3.5.1
*  Update NEWS
*  --version reports the right version


^L
Major changes in release 3.5

*  Change source license to GPLv3+
*  Do not include Henry Spencer V8 regex library
*  Change documentation license to FDL 1.3+
*  Use automake
*  Use the start of the week day specified by the locale
*  Typo fixed in data/dates/lotr: Sm8 = Smaug
*  Typo fixed in src/help.c and *.po: assigments -> assignments
*  Hyphens corrected in gcal.1
*  Date of Nikolaustag changed in data/dates/world
                 Bug report and patch by Wolfram Kleff
*  Spell check in doc/en/texi/gcal.texi
     Patch by James Troup
*  Do not install files in $(HOME)
                 Patch by Edward Betts
*  Add --from-code=iso-8859-1 to po/Makefile.in.in
           Patch by Sandro Tosi
*  Fix German translation
           Patch by Jens Seidel
*  Changes to src/{hd-data2.c,hd-data3.c,hd-defs.h,hd-data.c}
     -fixed Czech holidays; bug report and patch by Martin Mares
     -removed non ASCII char
     -All Saints Day on some states; patch by Marc-Jano Knopp
     -All Souls day is no holiday; patch by Thorsten Alteholz


^L
Major changes in release 3.01.1

* typos fixed in data files
* typo fixed in src/help.c
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-04-12 19:19:02 UTC
Created attachment 227511 [details, diff]
Ebuild patch

I am not sure the flag-o-matic and toolchain-funcs functions are still needed
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-12 19:24:35 UTC
(In reply to comment #2)

> I am not sure the flag-o-matic and toolchain-funcs functions are still needed

Those functions were before my time but it looks like they are there for QA reasons (respect CC, etc).

Thanks for the patch, please feel free to commit if you tested it.

Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-12 19:25:24 UTC
(In reply to comment #3)

> Thanks for the patch, please feel free to commit if you tested it.

Ah, I only thought shell-tools was in metadata. Sorry. 

Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2010-04-12 19:33:03 UTC
(In reply to comment #2)
> Created an attachment (id=227511) [details]
> Ebuild patch
> 
> I am not sure the flag-o-matic and toolchain-funcs functions are still needed

Also, einstall can be safely replaced with `emake DESTDIR="${D}" install' now and 3.5.1 throws up a QA issue:

 *      configure: WARNING: unrecognized options: --enable-ncurses

which should probably be replaced with:

  --disable-term          do not use libncurses/libtermcap/libtermlib

which could mean the USE=ncurses flag/description may or may not need some refinement.

Also, the dosed fails because emake install (or einstall for that matter) doesn't install anything in /usr/share/gcal/misc. Maybe that was moved or has come to depend on another configure flag which is disabled by default.
Comment 6 Ulrich Müller gentoo-dev 2010-04-13 08:03:23 UTC
I like bug reports where most of the work is already done. ;-)

Any specific reason for dropping the "iso3166" patch? Its changes have been accepted upstream (for version 4.0), see bug 144813. So I think it should be forward ported to 3.5.1.
Comment 7 Ulrich Müller gentoo-dev 2010-04-13 10:29:28 UTC
I'm inclined to skip this release because it has serious issues:
- NLS support has been removed
- translated documentation has been removed
- manpage is missing from tarball
- unicode support is broken

Comment 8 Ulrich Müller gentoo-dev 2010-04-15 10:18:37 UTC
The NEWS file for 3.5 poses more question than answers:

  *  Change source license to GPLv3+
  *  Do not include Henry Spencer V8 regex library
  *  Change documentation license to FDL 1.3+
  *  Use automake
  These don't provide direct benefits for users.

  *  Do not install files in $(HOME)
  *  Add --from-code=iso-8859-1 to po/Makefile.in.in
  These were already fixed in gcal-3.01-r3.

  *  Hyphens corrected in gcal.1
  *  Fix German translation
  The manpage and the German translation are not included in the tarball any
  more. I assume it was not done intentionally, if they are mentioned in NEWS.

  *  Typo fixed in src/help.c and *.po: assigments -> assignments
  No *.po files are included in the tarball.

  *  Typo fixed in data/dates/lotr: Sm8 = Smaug
  *  Date of Nikolaustag changed in data/dates/world
  *  Spell check in doc/en/texi/gcal.texi
  *  Changes to src/{hd-data2.c,hd-data3.c,hd-defs.h,hd-data.c}
       -fixed Czech holidays
       -removed non ASCII char
       -All Saints Day on some states
       -All Souls day is no holiday
  Leaves us with these small bug fixes, which could be easily backported
  to 3.01. (But I want to wait for a reply from upstream before doing that.)

I've contacted upstream two days ago for the issues of the removed NLS
support and the missing files in the tarball. No answer so far.
Comment 9 Giuseppe Scrivano 2010-04-27 21:39:45 UTC
Hello,

I made a new alpha release, would you mind to try it?

ftp://alpha.gnu.org/gnu/gcal/gcal-3_5_1.6-f841.tar.bz2
Comment 10 Ulrich Müller gentoo-dev 2010-04-28 05:07:40 UTC
(In reply to comment #9)
> I made a new alpha release, would you mind to try it?

Could you please include my ISO 3166 region code patch (which I had sent to Thomas Esken long time ago)? It can be found in bug 144813 comment #1.
Comment 11 Giuseppe Scrivano 2010-05-08 14:39:43 UTC
I have prepared a new package here:

ftp://alpha.gnu.org/gnu/gcal/gcal-3_5_1.16-3d1c.tar.bz2

your patch is included.  If there are not other errors I will do a release during the next week.

Thanks.