Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 314499

Summary: sys-apps/pciutils-3.1.7 version bump
Product: Gentoo Linux Reporter: MT <toffanin.mauro>
Component: New packagesAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: enhancement CC: bsd+disabled
Priority: High    
Version: 10.0   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 262321    
Attachments: pciutils-3.1.7-Makefile.patch
pciutils-3.1.7-fbsd.patch
pciutils-3.1.7.ebuild

Description MT 2010-04-10 11:36:06 UTC
Attached there is a new and improved ebuild for pciutils 3.1.7.

Changes done to the ebuild:
- added EAPI=2;
- stripped all the useless hard-coded compiler flags (they are just warning flags tha slow down compilation time and nothing else) and fixed Makefile's CFLAGS declaration so it can use directly the system cflags without the need to explicitly declare them with the 'OPT' parameter;
- fixed compilation issue for Gentoo/FreeBSD (see bug #262321 for reference);
- avoided the usage of the 'sed' utility to patch LIBDIR declaration;

I have tested the new ebuild for both Gentoo/Linux and Gentoo/FreeBSD (x86 arch) and it compiles and works fine.

Hope to be useful.
Toffanin
Comment 1 MT 2010-04-10 11:37:25 UTC
Created attachment 227241 [details, diff]
pciutils-3.1.7-Makefile.patch
Comment 2 MT 2010-04-10 11:38:31 UTC
Created attachment 227243 [details, diff]
pciutils-3.1.7-fbsd.patch
Comment 3 MT 2010-04-10 11:39:54 UTC
Created attachment 227245 [details]
pciutils-3.1.7.ebuild
Comment 4 SpanKY gentoo-dev 2010-04-10 19:28:50 UTC
i'm interested in minimizing the changes needed to the package (i.e. patches), so ive stuck with existing patches

now in the tree, thanks
Comment 5 MT 2010-04-11 07:27:55 UTC
(In reply to comment #4)
> i'm interested in minimizing the changes needed to the package (i.e. patches),
> so ive stuck with existing patches

thank very much for the quick reply/commit Vapier, but you forgot the 'sed' inside the src_prepare() phase which is redundant if you use LIBDIR="\${PREFIX}/$(get_libdir)" into the pemake() function; however it's not a big problem to have both of them.
Comment 6 SpanKY gentoo-dev 2010-04-11 19:32:29 UTC
i thought i dropped it, but i guess i edited the wrong file

http://sources.gentoo.org/sys-apps/pciutils/pciutils-3.1.7.ebuild?r1=1.1&r2=1.2