Summary: | mail-client/claws-mail-3.7.5 fails with libetpan 1.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Didier Barvaux <didier-bugzillagentoo> |
Component: | Current packages | Assignee: | Christian Faulhammer (RETIRED) <fauli> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | ken69267, net-mail+disabled, radhermit |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2162 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 313097 | ||
Attachments: |
Fix check for libetpan version in configure.ac
Patch to apply the bugfix in the claws-mail/claws-mail-3.7.5 ebuild Ebuild updates for claws-mail-3.7.5-r1 |
Description
Didier Barvaux
2010-04-09 17:05:51 UTC
Created attachment 227149 [details, diff]
Fix check for libetpan version in configure.ac
Created attachment 227151 [details, diff]
Patch to apply the bugfix in the claws-mail/claws-mail-3.7.5 ebuild
We could also take this opportunity to use at least EAPI 2 for the src_prepare and src_configure phases instead of using the src_unpack and src_compile phases. In addition, we might consider setting some decent IUSE defaults (supported by EAPI 1 and later) so things like imap support are included by default. Created attachment 227227 [details, diff]
Ebuild updates for claws-mail-3.7.5-r1
Ebuild updates for claws-mail-3.7.5-r1:
* Use EAPI 2 for src_prepare and src_configure phases
* Use autotools eclass for eautoreconf call
* Add a couple IUSE defaults
* Use src_prepare phase to apply the attached patch to fix the configure bug with >libetpan-0.57
* Use src_configure instead of src_compile (use default src_compile phase so the emake call is unnecessary)
* Organize code that sets libetpan and gnutls configure flags -- adds a few more lines to the ebuild, but the code seems clearer rather than always setting the disable flags and then tacking enable flags on top if the correct USE flags are enabled
* Explicit die for econf is unnecessary since it automatically calls die if the configure script fails
(In reply to comment #4) > Created an attachment (id=227227) [details] > Ebuild updates for claws-mail-3.7.5-r1 Successfully tested on my system with libetpan-1.0. Thanks Tim. mail@akhuettel.de: Please respect metadata.xml if you are going to wrangle bugs. Thanks in advance. FWIW, I was just trying out claws-mail and also think that +imap would be a great improvement! re-compiles are not fun for what most people consider basic use of a mail-client! :) Thank you for Will do both packages soon. Does libetpan 1.0 have anymore side-effects (like API/ABI change)? (In reply to comment #7) > Thank you for Will do both packages soon. Does libetpan 1.0 have anymore > side-effects (like API/ABI change)? I think there's a small API change and the soname version has changed. (In reply to comment #6) > mail@akhuettel.de: Please respect metadata.xml if you are going to wrangle > bugs. Thanks in advance. Oops sorry. Next time better. Seems I have not actually memorized the entire tree's metadata yet... :o) (In reply to comment #8) > (In reply to comment #7) > > Thank you for Will do both packages soon. Does libetpan 1.0 have anymore > > side-effects (like API/ABI change)? > > I think there's a small API change and the soname version has changed. > You're right for the API change, see a fragment of the changelog below: 2010-04-05 - libetpan-0.58cvs19 - hoa * build-mac/update.sh import of OpenSSL (prepare build for iPhone including OpenSSL) * src/driver/implementation/pop3/pop3driver.c * src/driver/implementation/pop3/pop3driver_cached.c * src/driver/implementation/pop3/pop3driver_tools.c * src/low-level/pop3/mailpop3.[ch] better error checking (2888850). Thanks to Alexander Shlemin. API change. I've tracked the API change, it seems to be a change of return type for the mailpop3_list() functions provided in /usr/include/libetpan/mailpop3.h. See http://libetpan.cvs.sourceforge.net/viewvc/libetpan/libetpan/src/low-level/pop3/mailpop3.h?r1=1.18&r2=1.19 for a diff of the change. You are also right for the soname version: 0.57 -> libetpan.so.13.1.2 0.58 -> libetpan.so.13.1.3 1.0 -> libetpan.so.15.0.0 Thank you for your support, I incorporated all of these changes. Work without any problem with libetpan 1.0. I close the bug. |