| Summary: | media-sound/lash: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | idella4 |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 391903 | ||
| Bug Blocks: | 308257 | ||
| Attachments: |
ebuild patch
revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch |
||
Created attachment 293127 [details, diff]
ebuild patch
(In reply to comment #1) Delete 'python? ( dev-lang/python )' from RDEPEND. Don't change DESTDIR="${D}" to DESTDIR="${ED}". Created attachment 293309 [details, diff]
revised ebuild patch
(In reply to comment #3) Why you deleted call to python_set_active_version(), which was present in previous patch? Created attachment 293655 [details, diff]
revised ebuild patch
(In reply to comment #5) * QA Notice: Static libraries have been found in Python site-packages * directories. Build system should be modified to not generate * these files and object files generated only for these files. * /usr/lib64/python2.7/site-packages/_lash.a * QA Notice: Libtool libraries have been found in Python site-packages * directories. These files should not be installed. * /usr/lib64/python2.7/site-packages/_lash.la Call python_clean_installation_image() to delete _lash.la. pkg_postinst() { python_mod_optimize lash.py } pkg_postrm() { python_mod_cleanup lash.py } Created attachment 293799 [details, diff]
revised ebuild patch
As you pointed out, the making of lash.py currently fails due to an autotool. Predictably;
* python_mod_optimize(): 'lash.py' does not exist
so the patch is likely right, an autotool not.
(In reply to comment #7) Call python_clean_installation_image() only with USE="python". Created attachment 293971 [details, diff]
revised ebuild patch
Fixed without a revbump. In fact, earlier today already but I've missed python_mod_* in pkg_* phases and added those now Closing, thanks for reporting & the work |
- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation [1] to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation [1]. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation [1]. - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml