Bug 313939 – media-sound/codecgraph: Verify and potentially improve Python-related code

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-04-08 19:41:25 UTC]

- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Ian Delaney (RETIRED) 2011-11-12 16:39:41 UTC]

Created attachment 292299 [details, diff]
ebuild patch

good for ABI {2.6 2.7 3.1 3.2}

Tested, all AOK.  Only adjusted most recent, adjustments undoubtedly can apply to others.  version bumped to EAPI 4, special treatment for Chainsaw.

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-13 02:35:41 UTC]

(In reply to comment #1)

Portage itself requires Python >=2.6 and it has no relation to Python version
required by other packages. If you install sys-apps/portage with USE="python3",
then you will be able to set active version of Python 2 to 2.4 or 2.5 and still
use Portage (Portage will use active version of Python 3 regardless of active
version of Python 2).

Such pkg_setup() is not needed.
Shebang in codecgraph.py should be fixed.

[Comment 3 Ian Delaney (RETIRED) 2011-11-14 09:32:37 UTC]

Created attachment 292497 [details, diff]
ebuild patch revised

done

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-14 19:52:51 UTC]

(In reply to comment #3)

Use PYTHON_DEPEND="2".

[Comment 5 Ian Delaney (RETIRED) 2011-11-15 08:47:24 UTC]

Created attachment 292607 [details, diff]
revised ebuild patch

this is known practice!!..  see how Chainsaw like it now.

[Comment 6 Tony Vroon (RETIRED) 2012-04-20 10:54:57 UTC]

+*codecgraph-20120114 (20 Apr 2012)
+
+  20 Apr 2012; Tony Vroon <[e-mail]>
+  +files/20120114-makefile-prefix.diff, -codecgraph-20080422.ebuild,
+  -codecgraph-20080507.ebuild, +codecgraph-20120114.ebuild:
+  Version bump, incorporating ebuild improvements by Ian "idella4" Delaney that
+  have been reviewed by Arfrever Frehtes Taifersar Arahesis in bug #313939.