| Summary: | stabilize =media-sound/mixxx-1.7.2 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Samuli Suominen (RETIRED) <ssuominen> |
| Component: | Current packages | Assignee: | Gentoo Developers for the x86 Architecture <x86> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | enhancement | CC: | alex, binki |
| Priority: | High | Keywords: | STABLEREQ |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 309809 | ||
| Attachments: |
patch for external libsoundtouch 1.5.0
updated ebuild internal libsoundtouch 1.7.2 with USE=ipod |
||
|
Description
Samuli Suominen (RETIRED)
2010-04-08 18:36:40 UTC
Could you please fix this QA issue before I mark it stable for amd64? Thanks * QA Notice: Files built without respecting LDFLAGS have been detected * Please include the following list of files in your report: * /usr/bin/mixxx Created attachment 227565 [details, diff]
patch for external libsoundtouch 1.5.0
patch for external libsoundtouch 1.5.0. Mixxx does ship with its own updated version of 1.4.0 that was never released as 1.4.1. I believe those upstream changes came down in 1.5.0. The patch also cleans up some invalid qt4 folders that are not needed during linking. Both patches were adapted from the Debian package.
Created attachment 227567 [details]
updated ebuild
This should solve the amd64 problems with the ld flags. Additional improvements include:
using j options > 1
using the correct cxx compiler (I know its dirty but its scons)
removed extra cflags like -g, -pipe and -O3
removed use flags that do not work (ipod shout djconsole ladspa tonal)
forced on features that should be included (vinylcontrol hifieq)
moved libsoundtouch to the external library (patch sent upstream)
added some missing depends libmad && ogg
Known issues: qt4.6 is fighting with mixxx. This goes back to 1.6 and probably further. Everything works fine with 4.5 but on 4.6 there is screen corruption on waveform 1. Upstream is looking into the issue but none of us have been able to figure it out yet. Workaround is to reload the skin and force a gui reboot.
The patch for an external libsoundtouch allows for easier sse optimization but version 1.5.0 isn't even in the tree. So if you would like to remove it just remove the epatch line and the depend. I was tested both with and without on amd64 and x86.
The scons cxx compiler fix is the official fix without patching scons ;)
The djconsole removal does not seem to have any effect on midi devices.
If you are still getting the ldflags warnings can you please post emerge --info.
Should this depend on bug 312957 ? (In reply to comment #4) > Should this depend on bug 312957 ? Nope the patch should go into a separate bug report depending on bug 312957. This is for stabilisation of 1.7.2 only. What you guys want to do with the patch is totally up to you. I just included it because I was convinced someone would complain that it wasn't externalized. It has worked just fine with the internal version for a long time now. I haven't noticed any ill effects of using the external 1.5.0 version but it is obviously now well tested. I am going to push upstream to decouple the projects for the 1.8.0 release so hopefully this patch will not be needed in the future. - Removing the external libsoundtouch patch is a simple as removing the dependency and epatch lines. (In reply to comment #6) > What you guys want to do with the patch is totally up to you. I just included > it because I was convinced someone would complain that it wasn't externalized. The problem is, that you put it here and it gets forgotten, so a separate bug report is better. One bug per issue. Indeed open a new bug and attach your ebuilds. We will make it blocker to this bug if necessary. However the LDFLAGS issue should be fixed before we stabilize this Created attachment 227821 [details] internal libsoundtouch This is fixed to use the internal (to mixxx) libsoundtouch. I have tested with some custom ldflags and see no warnings or errors. Bug 315349 was created to externalize libsoundtouch. I tested with custom ldflags and I have no issues. amd64 will skip this then (no previous stable keyword), but x86 should stabilize since it's not a regression. we will try to handle the LDFLAGS issue for 1.8.0 (see bug 317519) Created attachment 230459 [details]
1.7.2 with USE=ipod
The 1.7.2 version fails for me with USE=ipod on x86!
The 1.7.2-r1 version depends on >=media-libs/libsoundtouch-1.5.0, which is keyworded right now...
(In reply to comment #11) > Created an attachment (id=230459) [details] > 1.7.2 with USE=ipod > > The 1.7.2 version fails for me with USE=ipod on x86! > The 1.7.2-r1 version depends on >=media-libs/libsoundtouch-1.5.0, which is > keyworded right now... > Try http://bugs.gentoo.org/attachment.cgi?id=227821 which does not have the use flags that the current 1.7.2 in the trunk has and it also doesn't depend on libsoundtouch. The soundtouch ebuild was moved to bug 315349. The use flags other than debug pulseaudio are experimental and have been removed. ok, deleted everything but latest, the package shouldn't be marked stable in current condition. (In reply to comment #12) > Try http://bugs.gentoo.org/attachment.cgi?id=227821 which does not have the use ok, that one worked for me without a hitch! :-) |