Summary: | media-gfx/inkscape: Verify and potentially improve Python-related code | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
Component: | Current packages | Assignee: | Gentoo Graphics Project <graphics+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | idella4 |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 223067 | ||
Bug Blocks: | 308257 | ||
Attachments: |
ebuild patch
revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch revised ebuild patch |
Description
Arfrever Frehtes Taifersar Arahesis (RETIRED)
2010-04-06 17:29:23 UTC
Arfrever, notice also bug 223067... Patches are accepted, but otherwise this is a very low priority to the graphics team, sorry. Created attachment 292655 [details]
ebuild patch
supports most all python versions.
(In reply to comment #2) This package doesn't support Python 3. Created attachment 292839 [details, diff]
revised ebuild patch
(In reply to comment #4) Delete '|| ( dev-lang/python[xml] dev-python/pyxml )' from COMMON_DEPEND. Call 'python_set_active_version 2' before 'python_pkg_setup'. python_mod_optimize() and python_mod_cleanup() should be called. See bug #223067. Created attachment 292993 [details, diff]
revised ebuild patch
thx Arfrever
(In reply to comment #7) Use PYTHON_DEPEND="2". src_postint() and src_postrm() functions are not used by package managers. You should define pkg_postinst() and pkg_postrm(). python_mod_optimize() and python_mod_cleanup() require at least 1 argument. Created attachment 293307 [details, diff]
revised ebuild patch
hmm, a correction again. pkg_postrm() { python_mod_cleanup "${ED}" } remove arg "-r" (In reply to comment #9 and comment #10) PYTHON_DEPEND="2" python_mod_optimize() and python_mod_cleanup() require paths to Python modules, relative to "${EROOT%/}" or site-packages directories. Created attachment 293665 [details, diff]
revised ebuild patch
(In reply to comment #12) Re-read comment #11. Created attachment 293809 [details, diff]
revised ebuild patch
sorry, missed it
(In reply to comment #14) The second suggestion from comment #11 means: pkg_postint() { python_mod_optimize /usr/share/${PN}-extensions } pkg_postrm() { python_mod_cleanup /usr/share/${PN}-extensions } Created attachment 294015 [details, diff]
revised ebuild patch
got caught out by my own typo, - in place of /. anyway this works
Python related stuff should be fine in 0.48.4-r1 now. |