Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 313493

Summary: media-gfx/exiv2: Verify and potentially improve Python-related code
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever>
Component: Current packagesAssignee: Stefan Briesenick (RETIRED) <sbriesen>
Status: RESOLVED FIXED    
Severity: normal    
Priority: High    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 308257    

Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-04-06 17:25:07 UTC
- If this package can be used as a library and installs Python modules
  (*.so or *.py) into site-packages directories, then consider supporting
  installation for multiple Python versions.
  Please read section "Types of packages" in documentation [1] to decide
  if this package can support installation for multiple Python versions.

- Ensure that the ebuilds do not use deprecated functions or variables.

- Please check if Python 3 is supported by this package. You can temporarily
  set Python 3 as main active version of Python to properly test if this
  package supports Python 3.

- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
    Please read section "Specification of dependency on Python" in
    documentation [1].

  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().

  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)
    Please read section "Shebangs in installed scripts" in documentation [1].

  - To ensure that changes applied to the ebuilds are sufficient, please
    temporarily set Python 3 as main active version of Python and test if
    this package can be properly installed and if it works at run time.

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Stefan Briesenick (RETIRED) gentoo-dev 2010-07-20 19:33:27 UTC
hmmm. Python is only needed for building the docs. So it doesn't install any python modules. But: ebuild fail if used with python 3.1.

I try to investigate what to do.
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-07-20 19:37:38 UTC
DEPEND="...
	doc? (
		=dev-lang/python-2*
		..."

pkg_setup() {
	if use doc; then
		python_set_active_version 2
		python_pkg_setup
	fi
}
Comment 3 Stefan Briesenick (RETIRED) gentoo-dev 2010-07-20 20:50:04 UTC
no, that's not the right thing ;)

it's just a small python script doc/templates/gen.py, which is only used for generating the docs.

I did a version bump and fixed it there. I had to use the
shebang-patch-feature, because of the "print is now a function" change in
python3. Though it's a nice feauture, it breaks all old scripts. :-(

I don't want to fix the old versions until anyone complains. All old versions
are stable and I don't want to touch them.

But I will remove the oldest version.