Summary: | games-simulation/openttd version bump 1.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Opportunist <axiator> |
Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | admin, alecm_88, amigadave, bas, david, deduktionstheorem, jarauh, koesterreich, nik, roehner, tuupic, Wizzleby |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 300328, 308355 | ||
Bug Blocks: | |||
Attachments: |
openttd-1.0.0.ebuild
openttd-1.0.0.ebuild openttd-0.7.5-to-1.0.0.ebuild.patch metadata.xml.patch openmsx-0.2.1.ebuild openmsx-0.2.1.ebuild openttd-1.0.0-build.patch openttd-1.0.0.ebuild openttd-1.0.0.ebuild |
Description
Opportunist
2010-04-03 16:39:28 UTC
*** Bug 313057 has been marked as a duplicate of this bug. *** Yes! We want this :-) I simply renamed the 0.7.5 ebuild to 1.0.0 and it works for me on amd64. No, we're not going to do that. 1.0 will have the open media support added. Created attachment 226849 [details]
openttd-1.0.0.ebuild
=games-simulation/openttd-1.0.0.ebuild
Created attachment 226851 [details]
openttd-1.0.0.ebuild
=missed a few obsolete elogs, tweaked the elogs to be more relevant
(In reply to comment #5) > Created an attachment (id=226849) [details] > openttd-1.0.0.ebuild > > =games-simulation/openttd-1.0.0.ebuild > emerge: there are no ebuilds to satisfy "games-misc/opensfx". (dependency required by "games-simulation/openttd-1.0.0" [ebuild]) First u need add to portage: games-misc/opengfx games-misc/opensfx games-misc/openmsx Created attachment 226853 [details, diff]
openttd-0.7.5-to-1.0.0.ebuild.patch
the same as above, in diff form
Created attachment 226855 [details]
metadata.xml.patch
metadata.xml updates wrt new USE flag
Just relalized I left the maintainer line in metadata.xml when porting it from gamerlay. It can either be taken out, or considered as an offer to proxy maintain openttd + deps (In reply to comment #7) > (In reply to comment #5) > > Created an attachment (id=226849) [details] [details] > > openttd-1.0.0.ebuild > > > > =games-simulation/openttd-1.0.0.ebuild > > > > emerge: there are no ebuilds to satisfy "games-misc/opensfx". > (dependency required by "games-simulation/openttd-1.0.0" [ebuild]) > > First u need add to portage: > games-misc/opengfx > games-misc/opensfx > games-misc/openmsx > Yes, see bugs 300328, 308355, exist for opengfx, opensfx, and their respective build dependencies which are not in tree. No bug exists for openmsx, so I will attach it to this bug Created attachment 226857 [details]
openmsx-0.2.1.ebuild
games-misc/openmsx-0.2.1.ebuild
Created attachment 226889 [details]
openmsx-0.2.1.ebuild
games-misc/openmsx-0.2.1
inherit python, set active version of python to 2, clean up quoting
Thanks a lot! Works great for me on ~amd64 Created attachment 227765 [details, diff]
openttd-1.0.0-build.patch
Comment on attachment 227765 [details, diff]
openttd-1.0.0-build.patch
Separate CFLAGS and CXXFLAGS, don't pass CFLAGS to CXX, and make sure that CXXFLAGS and CFLAGS both contain enough info to compile
Upon discussion with upstream, I am chagrined to discover that the build patch may be unecessary. If it is not a bad thing, CFLAGS may be overridden with CXXFLAGS, or CFLAGS passed as a blank string to the configure script. Openttd is compiled entirely with the C++ compiler. Upstream incorporates CFLAGS because that is the workflow of their developers: to pass options with CFLAGS. I have tested the ebuild with the configure line starting as: CFLAGS="" ./configure I also tested with CFLAGS=${CXXFLAGS} though that results in the contents of CXXFLAGS being passed twice. Overriding CFLAGS with an empty string does prevent passing the contents of a user's CFLAGS (provided they don't simply CXXFLAGS=${CFLAGS} in /etc/make.conf), but I am unsure if it is The Right Thing to do. Created attachment 227951 [details]
openttd-1.0.0.ebuild
The alternative to the build.patch. CFLAGS= ./configure
Created attachment 227953 [details]
openttd-1.0.0.ebuild
The alternative to the build.patch. CFLAGS="" ./configure
in portage. thanks for the bug report and ebuild. |