Summary: | latest autotools.eclass has_version fix to fix non-/ ROOT builds | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Daniel Robbins <drobbins> |
Component: | Eclasses | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | major | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=655326 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Daniel Robbins
2010-04-01 18:08:30 UTC
committed now in in rev 1.97. Can you please link to a actual raw patches rather than just github? They don't offer any way to get a straight patch short of cloning the repo and extracting it yourself. For this patch it was simple, but I've been given larger ones where it's a PITA to do manually. (And you can't copy and paste because their line numbers get brought in. P.S. Re the quotes, check your editor for UTF8 mangling, the quotes there are actually UTF8 chars ;-). Seems like github might want to add a feature to extract a standard patch from the commit page, but I'll keep that in mind for future bug reports. yep, I'll need to look into what vim is doing. default vim config. Thanks for applying this to the Gentoo tree. -Daniel The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81f5aea4dedb55fdc18723a93ee2ba5d39b3053b commit 81f5aea4dedb55fdc18723a93ee2ba5d39b3053b Author: Sam James <sam@gentoo.org> AuthorDate: 2022-04-29 01:42:11 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-04-30 19:13:32 +0000 autotools.eclass: drop ROOT=/ in has_version call Noticed when doing a read-through of the eclass (which is how I noticed c8e74a7dfe477dea008548553141f083c5d03782 too). Forcing ROOT=/ is, at best, going to confuse matters, and at worst, do entirely the wrong thing. In EAPI 5 and 6, we had --host-root (which we use in the eclass), and in EAPI 7+, we have -b/-d (which we use in the eclass too). The ROOT= setting was there for pre-EAPI 5 times. The aforementioned toggles (--host-root and then later on, -b/-d) are the correct methods to specify (B)ROOT for has_version. Using one of those with ROOT= have undefined behaviour, so drop it. Bug: https://bugs.gentoo.org/312687 Thanks-to: James Le Cuirot <chewi@gentoo.org> Thanks-to: Ulrich Müller <ulm@gentoo.org> Signed-off-by: Sam James <sam@gentoo.org> eclass/autotools.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |