|Summary:||app-text/nfoview: Verify and potentially improve Python-related code|
|Product:||Gentoo Linux||Reporter:||Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever>|
|Component:||Current packages||Assignee:||SpanKY <vapier>|
|Package list:||Runtime testing required:||---|
|Bug Depends on:|
|Attachments:||New -9999.ebuild and -1.9.1.ebuild|
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-30 16:51:54 UTC
- If this package can be used as a library and installs Python modules (*.so or *.py) into site-packages directories, then consider supporting installation for multiple Python versions. Please read section "Types of packages" in documentation  to decide if this package can support installation for multiple Python versions. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. You can temporarily set Python 3 as main active version of Python to properly test if this package supports Python 3. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. Please read section "Specification of dependency on Python" in documentation . - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please read section "Shebangs in installed scripts" in documentation . - To ensure that changes applied to the ebuilds are sufficient, please temporarily set Python 3 as main active version of Python and test if this package can be properly installed and if it works at run time. Please see documentation  for more details.  http://www.gentoo.org/proj/en/Python/developersguide.xml
Comment 1 Samuli Suominen (RETIRED) 2010-06-29 07:03:34 UTC
Created attachment 236881 [details, diff] New -9999.ebuild and -1.9.1.ebuild Patch against current -9999.ebuild, runs also icon cache update for hicolor icons and mime update for the Mime= in the .desktop entry. And also a version bump to nfoview-1.9.1 (same ebuild for both)
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-06-29 07:13:29 UTC
(In reply to comment #1) This patch looks good.
Comment 3 SpanKY 2010-06-29 18:50:32 UTC
i'm not familiar with any of those eclasses, so feel free to commit if the program itself still works
Comment 4 Samuli Suominen (RETIRED) 2010-06-29 19:05:41 UTC
thanks guys. committed.