Bug 3113 – Minor error in gnome-extra/mc ebuilds, samba related

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Christophe Vanfleteren 2002-05-28 08:23:08 UTC]

Hi,

I just discovered an error in the mc-4.5.55-r4 ebuild:

when the use variable samba is set, there is a sed command being run against 
smbfs.c, wich sets the right path to the smb.conf file.
Now since that location has changed from /etc/smb to /etc/samba, the sed is no
longer correct and should be corrected.
There is also a problem with the codepages: mc seaches for them in
$LIBDIR/codepages (wich becomes /usr/lib/codepages after compiling), but it
should be /var/lib/samba/codepages. I grepped for codepages, and the only file
that seems like a candidate for adjusting is vfs/samba/Makefile.in
I changed the CODEPAGEDIR to /var/lib/samba/codepages, but that didn't seem to
work, and I don't know anything about the wonderful world of makefiles, so I
don't know where to adjust it, but it should be fairly trivial I guess.

Christophe Vanfleteren

[Comment 1 Maik Schreiber 2002-05-31 13:54:23 UTC]

Created attachment 1273 [details]
patch for mc-4.5.55-r4

This patch fixes the following in mc-4.5.55-r4 when the samba USE flag is set:

- "/etc/smb/smb.conf" -> "/etc/samba/smb.conf"
- "/usr/lib/codepages" -> "/var/lib/samba/codepages"

[Comment 2 Maik Schreiber 2002-05-31 13:58:35 UTC]

Created attachment 1274 [details]
patch for mc-4.5.55-r4

This patch fixes the following in mc-4.5.55-r4 when the samba USE flag is set:

- "/etc/smb/smb.conf" -> "/etc/samba/smb.conf"
- "/usr/lib/codepages" -> "/var/lib/samba/codepages"

(I've removed the "einfo" line I left in there in the previous patch. Sorry
about that.)

[Comment 3 Seemant Kulleen (RETIRED) 2002-06-08 17:29:26 UTC]

*** Bug 3486 has been marked as a duplicate of this bug. ***

[Comment 4 Seemant Kulleen (RETIRED) 2002-06-20 15:28:08 UTC]

Maik, thanks for a great fix!  Sorry to have taken so long in updating mc's
ebuild with it.  It is now in portage -- look for your name in the ChangeLog :)