Bug 310827

Summary:	New package: kde-misc/basket-1.80 for KDE4
Product:	Gentoo Linux	Reporter:	Scott Stubbs <scott.stubbs>
Component:	Current packages	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	bugs
Priority:	High	Keywords:	EBUILD
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://basket.kde.org/
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	ebuild for basket-1.80 Patch adding a kde-base/qimageblitz dependency Patched basket-1.80.ebuild with added keywords

Description Scott Stubbs 2010-03-23 07:21:12 UTC

Basket 2.0 is about to be released. So I've made an ebuild that will build the beta (version 1.80). And I'll update it as the releases happen.

It's my first ebuild, so any comments are appreciated. Including the proper way to grab a tagged release in git, because I couldn't find documentation on that.

Reproducible: Always

Comment 1 Scott Stubbs 2010-03-23 07:22:28 UTC

Created attachment 224809 [details]
ebuild for basket-1.80

Comment 2 Samuli Suominen (RETIRED) gentoo-dev

2010-03-23 07:37:03 UTC

I don't know about that SRC_URI but homepage is indeed indicating 1.80 is out.

Comment 3 basti 2010-03-23 12:23:25 UTC

Please put it in portage main tree :)

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2010-03-24 15:17:51 UTC

Download link,

http://basket.kde.org/downloads/?file=basket-1.80
http://basket.kde.org/downloads/basket-1.80.tar.bz2

for sanity :)

Comment 5 Andreas K. Hüttel archtester

2010-03-28 21:13:45 UTC

Is in the kde overlay now, thanks for contributing!

Comment 6 Maciej Grela 2010-04-13 18:11:13 UTC

Created attachment 227633 [details]
Patch adding a kde-base/qimageblitz dependency

Here is a patch for the ebuild which adds a missing kde-base/qimageblitz dependency. Without it the following happens when building:

-- Found the KDE4 kconfig_compiler preprocessor: /usr/bin/kconfig_compiler
-- Found automoc4: /usr/bin/automoc4
-- Configuring incomplete, errors occurred!
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:70 (MESSAGE):
  Could NOT find QImageBlitz (missing: QIMAGEBLITZ_INCLUDES
  QIMAGEBLITZ_LIBRARIES)
Call Stack (most recent call first):
  /usr/share/apps/cmake/modules/FindQImageBlitz.cmake:48 (find_package_handle_standard_args)
  CMakeLists.txt:6 (find_package)

!!! ERROR in kde-misc/basket-1.80::kde:
!!! In enable_cmake-utils_src_configure at line 2605
!!! cmake failed

!!! Call stack:
!!!    * enable_cmake-utils_src_configure (/var/tmp/paludis/kde-misc-basket-1.80/temp/loadsaveenv:2605)
!!!    * _execute_optionaly (/var/tmp/paludis/kde-misc-basket-1.80/temp/loadsaveenv:696)
!!!    * cmake-utils_src_configure (/var/tmp/paludis/kde-misc-basket-1.80/temp/loadsaveenv:1391)
!!!    * kde4-base_src_configure (/var/tmp/paludis/kde-misc-basket-1.80/temp/loadsaveenv:4180)
!!!    * src_configure (/var/tmp/paludis/kde-misc-basket-1.80/temp/loadsaveenv:5235)
!!!    * ebuild_f_configure (/usr/libexec/paludis/2/src_configure.bash:54)
!!!    * ebuild_main (/usr/libexec/paludis/ebuild.bash:647)
!!!    * main (/usr/libexec/paludis/ebuild.bash:675)

Comment 7 Taras Bondarchuk 2010-04-22 13:03:22 UTC

Created attachment 228755 [details]
Patched basket-1.80.ebuild with added keywords

Comment 8 Dror Levin (RETIRED) gentoo-dev

2010-04-22 17:38:11 UTC

Added to the tree, thank you all for ebuilds and testing!

Taras, note that your ebuild is actually the live one and not 1.80, and that the convention is to put functions after all variables in the ebuild. Also, please attach patches in the future instead of the whole ebuild, makes it easier to spot changes. Thanks!