Bug 310805 – sys-apps/openrc-0.6.1 network script has syntax errors

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Leonid Podolny 2010-03-22 22:36:41 UTC]

looptop ~ # /etc/init.d/network stop
/etc/init.d/network: line 77: syntax error near unexpected token `)'
/etc/init.d/network: line 77: ` *)'
/etc/init.d/network: line 77: warning: syntax errors in . or eval will cause future versions of the shell to abort as Posix requires

[Comment 1 fkhp 2010-03-23 04:37:33 UTC]

maybe need add a line of  ";;" before  line  "*)" ? but this is need to be confirmed.

[Comment 2 Sharkman 2010-03-23 06:27:37 UTC]

=sys-apps/openrc-0.6.1

sharkman-work ~ # /etc/init.d/network status
/etc/init.d/network: line 77: syntax error near unexpected token `)'
/etc/init.d/network: line 77: ` *)'
 * status: started
sharkman-work ~ #

[Comment 3 Ceesjan Luiten 2010-03-23 08:59:36 UTC]

Created attachment 224819 [details, diff]
Patches syntax error and a few spurious indentations

[Comment 4 Lars Wendler (Polynomial-C) (RETIRED) 2010-03-23 16:28:16 UTC]

Upstream should know about this as well...

[Comment 5 Lars Wendler (Polynomial-C) (RETIRED) 2010-03-23 16:33:10 UTC]

Created attachment 224911 [details, diff]
openrc-0.6.1-network-initd-fix.patch

Cleaner patch without the useless whitespace fixes...

[Comment 6 Weeve 2010-03-23 19:44:09 UTC]

Seriously, how did this make it into the tree?

[Comment 7 Leonid Podolny 2010-03-23 19:47:20 UTC]

(In reply to comment #6)
> Seriously, how did this make it into the tree?
> 

These things happen to everyone, it's absolutely normal.

[Comment 8 SpanKY 2010-03-23 20:05:02 UTC]

Roy: `git log` on 0276c4f5164f053346dd585639161995ac0e6e75 also shows some whitespace damage in the new network code you might want to fix

ive added Lars' patch to 0.6.1-r1

Weeve: /etc/init.d/network isnt the default (/etc/init.d/net is), so i'm not surprised it slipped in.  i wouldnt have noticed it myself.

[Comment 9 SpanKY 2010-03-23 20:13:07 UTC]

also, ive added a shell syntax check to the QA post install to make sure this doesnt happen again to any ebuild

http://sources.gentoo.org/portage/main/trunk/bin/misc-functions.sh?r1=15842&r2=15843

[Comment 10 Roy Marples 2010-03-24 19:31:47 UTC]

My bad, I commited that bit by mistake. It's unfinished :/

[Comment 11 Roy Marples 2010-03-24 20:31:36 UTC]

http://roy.marples.name/projects/openrc/changeset/67b538fd262c72198e1b293f6bea314051034656

[Comment 12 William Hubbs 2010-04-13 14:08:39 UTC]

This is fixed in upstream git, so it will be in the next release.