Summary: | media-video/dvdstyler-1.8.0.2 - Version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Daniel Pielmeier <billie> |
Component: | Current packages | Assignee: | Daniel Black (RETIRED) <dragonheart> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | media-video |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
dvdstyler-1.8.0.2.diff
dvdstyler-1.8.0.2-autoconf.patch dvdstyler-1.8.0.2-autoconf.patch dvdstyler-1.8.1_beta1.diff |
Description
Daniel Pielmeier
2010-03-20 21:04:24 UTC
Daniel, If you want to add it go for it. Daniel Created attachment 224493 [details, diff]
dvdstyler-1.8.0.2.diff
Before I commit I will add my changes here for discussion.
Moved virtual/cdrtools >=media-video/dvdauthor-0.6.14 >=app-cdr/dvd+rw-tools-7.1 to COMMON_DEPEND as configure checks for them at compile time.
Added app-arch/zip to DEPEND as configure checks for it.
New autoconf patch as the previous one was not fully applied. docsdir is still redefined in docs/Makefile.am and mktemp is only used once. I guess you are in contact with upstream so you probably know why this part is missing.
Created attachment 224495 [details, diff]
dvdstyler-1.8.0.2-autoconf.patch
Created attachment 224553 [details, diff]
dvdstyler-1.8.0.2-autoconf.patch
It looks like upstream forgot to add the templates dir in the top Makefile.am. Updated patch so templates get installed else dvdstyler crashes if the files are missing and you want to use the provided templates.
looks ok. remember upstream took part of the patch. forget what they said about mktemp - its probably written on a sourceforge bug. I'm really happy if you take this package over or at least comaintained it. (In reply to comment #5) > looks ok. Good :) > remember upstream took part of the patch. forget what they said about mktemp - > its probably written on a sourceforge bug. I found your patch on SF. The only additional comment was that it has been applied. I asked the upstream author about it and also informed him about the templates issue. > I'm really happy if you take this package over or at least comaintained it. Hey I can not take all your packages :) Lets see if I add myself as co-maintainer. Created attachment 227535 [details, diff]
dvdstyler-1.8.1_beta1.diff
The attached beta version includes only minor changes and does now install the templates which were missing in 1.8.0.2.
The html% part does not really need mktemp as this is only used for updating the websites help content.
Docdir is respected but the help_lang.zip files are still placed at
/usr/share/dvdstyler/docs because dvdstyler is searching them there.
Using a --docdir for the complete documentation is on the upstream to-do list.
So I would say patching is not needed at the moment and the remaining issue about the doc patch will be fixed upstream in the next versions.
@Daniel are you okay with the new diff?
Bumped to dvdstyler-1.8.1_beta1. |