Bug 310383 – dev-lang/php: set useflag defaults in ebuilds instead of profile

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jonas Bernoulli 2010-03-20 14:13:21 UTC]

In /usr/portage/profiles/default/linux/make.conf we have this:

# 2006/04/19 - Chris Gianelloni <[e-mail]>
# Make sure dev-lang/php works right.  See bug #120088 for more info.
USE="${USE} cli pcre reflection session spl"

I believe that at least "reflection" and "spl" should not be set globally
but instead as a default in the php ebuilds.

I for one checked all globally enabled useflags manually to see what they
do / if I really want them to be enabled.  Since I do not use php it is
slightly annoying that this useflag is set globally.

This also applies to "pcre".  But since this is not only used by php
ebuilds furthur tests would have to be performed to see for what other
packages the default useflag setting has to be set.  On my system only
sys-apps/grep is affected (according to "euse -I pcre", are there any
tools to show all packages that have a certain useflag, whether installed
or not?)

"cli" and "session" are used by many packages.  Again the default value
should be set in the php ebuilds but then it also has to be discussed
whether to keep these flags set globally or not.  If it is agread that
these should be set globally and after the php ebuilds have been adjusted
the comment should be changed to something like "These are generally
desirable" instead of the current php specific comment.


Reproducible: Always

Steps to Reproduce:

[Comment 1 Doktor Notor 2010-03-21 12:47:06 UTC]

That'd be php5_2-sapi.eclass, not ebuilds.

[Comment 2 Matti Bickel (RETIRED) 2010-04-20 23:33:27 UTC]

Should be a non-issue with php-5.3, we do all the metadata wizardry in the ebuild now.

Additionally, from the first pages (eww!) of the referenced bug, we were missing some portage features so this workaround was required. I'll recheck if that's still the case.

[Comment 3 Matti Bickel (RETIRED) 2010-06-14 00:14:09 UTC]

In php-5.3.2 there are USE defaults and I'm looking into enabling +cli in addition to the recent switch to defaulting to upstream's built-in extensions.

I'm not going to tinker with php-5.2.* anymore, but note that php-5.2.13 autoselects USE="cli" if you don't choose a SAPI. So the build doesn't fail and the cause for the mentioned bug is gone.

Therefore I'd like to remove the USE line from make.defaults completely. As this is a major change, I'd like to gather comments from the php and release team as well as from the users and reach consensus after two weeks (that is 27th june). I'll move shortly thereafter.

Please discuss.

[Comment 4 Jonas Bernoulli 2010-06-14 18:26:51 UTC]

(In reply to comment #3)

Thanks for working on this.

> Therefore I'd like to remove the USE line from make.defaults completely. As
> this is a major change, I'd like to gather comments from the php and release
> team as well as from the users and reach consensus after two weeks (that is
> 27th june). I'll move shortly thereafter.
> 
> Please discuss.

I don't see releng in the CC list. Have you made them aware of this report in some other way?

[Comment 5 Matti Bickel (RETIRED) 2010-06-17 21:20:42 UTC]

I'm asking around on IRC, but CC'ing releng@ is probably a good idea, though the people who originally championed this idea have left.

[Comment 6 Matti Bickel (RETIRED) 2010-07-18 12:50:15 UTC]

No discussion :(

I've since moved to USE="+cli" and the upcoming php-5.2.14 will sport the same USE-defaults as php-5.3 already does.

In one more step, I'll blog about the issue and remove the profile stuff one week after the post.

[Comment 7 Peter Volkov (RETIRED) 2010-07-22 14:51:45 UTC]

(In reply to comment #6)
> No discussion :(

Does this change affect users in any way? If I understood you correctly this change is just about dropping unused line from profile and if so, just do it. )

[Comment 8 Matti Bickel (RETIRED) 2010-07-29 17:47:56 UTC]

It will be unused after we get something more recent than 5.2.13 stable. Before that, users will notice php not building any SAPI by default and the release team will kill me ;)

With php-5.3* and (soon to be) 5.2.14, USE defaults will take that place. I'll blog about that once I get 5.2.14 into the tree.

[Comment 9 Ole Markus With (RETIRED) 2010-10-19 20:19:22 UTC]

Stable PHP in the tree with sane defaults now.