Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 309883

Summary: sys-apps/setserial broken with sys-kernel/linux-headers-2.6.33 due to removal of linux/hayesesp.h
Product: Gentoo Infrastructure Reporter: Gary Stein <gstein>
Component: BugzillaAssignee: Gentoo's Team for Core System packages <base-system>
Status: RESOLVED FIXED    
Severity: normal CC: alles
Priority: High    
Version: unspecified   
Hardware: x86   
OS: Linux   
URL: http://permalink.gmane.org/gmane.comp.lib.uclibc.buildroot/20478
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: patch for ebuild
modified ebuild to apply patch
setserial.c patch
Ebuild patch

Description Gary Stein 2010-03-17 00:49:49 UTC 
As it says in the link, linux/hayesesp.h was apparently removed in 2.6.33, included in the linux is a patch...which pretty much just does a #undef TIOCGHAYESESP

For those that have old Hayes modems might be mad...but I can confirm it fixes the problem.  This is both x86 and amd64.

gary 

Reproducible: Always

Steps to Reproduce:
1.  Upgrade to linux headers 2.6.33 (in ~x86)
2.  Try to install setserial
3.  Fail on a error: storage size of 'esp' isn't known because hayesesp.h doesn't exist 

Actual Results:  
Crashes with error: storage size of 'esp' isn't known problem

Expected Results:  
compile fully

#undef TIOCGHAYESESP

on line 32 of setserial.c fixes it.

Of anyone still does serial stuff it is a nice set of tools to have.
Comment 1 Mark Breddemann 2010-03-22 23:24:30 UTC 
Created attachment 224787 [details, diff]
patch for ebuild
Comment 2 Mark Breddemann 2010-03-22 23:24:51 UTC 
Created attachment 224789 [details]
modified ebuild to apply patch
Comment 3 Mark Breddemann 2010-03-22 23:25:14 UTC 
Same here, fixed with the attached files.
Comment 4 SpanKY gentoo-dev 2010-03-23 20:39:44 UTC 
Comment on attachment 224789 [details]
modified ebuild to apply patch

post ebuild unified diffs, not entire ebuilds
Comment 5 SpanKY gentoo-dev 2010-03-23 20:40:18 UTC 
Comment on attachment 224787 [details, diff]
patch for ebuild

post unified diffs, not context -- these are terrible for reading and/or reviewing
Comment 6 Marcin Deranek 2010-03-25 20:51:49 UTC 
Created attachment 225257 [details, diff]
setserial.c patch
Comment 7 Marcin Deranek 2010-03-25 20:52:30 UTC 
Created attachment 225259 [details, diff]
Ebuild patch
Comment 8 Artur Frysiak 2010-03-26 15:14:54 UTC 
From linux-2.6 git repo:

commit f53a2ade0bb9f2a81f473e6469155172a96b7c38
Author: Alan Cox <alan@linux.intel.com>
Date:   Fri Oct 9 12:56:41 2009 +0100

    tty: esp: remove broken driver

    The ESP driver has been marked broken for years. It's an old ISA device
    that clearly nobody cares about any more. Remove it

    Signed-off-by: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 Documentation/serial/hayes-esp.txt |  154 ---
 drivers/char/Kconfig               |   13 -
 drivers/char/Makefile              |    1 -
 drivers/char/esp.c                 | 2533 ------------------------------------
 include/linux/Kbuild               |    1 -
 include/linux/hayesesp.h           |  114 --
 6 files changed, 0 insertions(+), 2816 deletions(-)
Comment 9 Sunit Das 2010-04-09 16:14:47 UTC 
So, are these patches good?  Bump?