| Summary: | New version (2.5-4) of MLdonkey released | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andre Hinrichs <andre.hinrichs> |
| Component: | Current packages | Assignee: | Heinrich Wendel (RETIRED) <lanius> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | george, greg_g, jrmalaq, lglaz |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
mldonkey-2.5.4.ebuild
Patch to change checking ocaml version |
||
|
Description
Andre Hinrichs
2003-10-12 12:37:21 UTC
it should compile with ocaml 3.07 now Forgot the list of changes. Here it is.
2003/10/12: Simon (release-2-5-4)
* Applied patches #2033 (hide-dirs), #2038 (ocaml-3.07),
#2039 (mlsubmit.reg), #2041 (hide-psswd)
2003/10/10: Simon
* Removed patch #1765
2003/10/09: Simon
* Applied patches #1608 (anti-thieves), #1669 (anti-spam),
#1692 (min-users-per-server), #1695 (html-mods),
#1710 (regexp in voo), #1711 (sorted voo),
#1714 (gui priority bug fix), #1715 (fasttrack),
#1732 (mldonkey_submit), #1733 (viewfiles 6 hours),
#1734 (browse-friends), #1743 (bittorrent compliance),
#1748 (emule-bugfix), #1753 (max-conn-servers),
#1765 (limit-reqs DANGER), #1801 (http-proxy),
#1843 (message-file), #1862 (download-amount),
#2024 (filenames), #2025 (friends-slots),
suxx-lugdunum-fix-v2
DELAYED: #1911 (hidden-chunks)
It does compile with OCaml 3.07, with the latest bug-fix patch applied (to OCaml). See bug #31265, where I attached an ebuild for ocaml-3.07 which applies such patch. Created attachment 19311 [details]
mldonkey-2.5.4.ebuild
My ebuild for mldonkey 2.5-4.
Note that it does not rely on ocaml-3.06*, and can be compiled with ocaml-3.07*
(ocaml-3.07 patched with latest bug-fix patch).
The ocaml-version is detected at compilation time.
A patch (next attachment) is applied in order to cleanly accept compilation
with patched ocaml versions, like the one mentioned earlier (3.07+2). Originaly
it would check strictly for 3.06 or 3.07 versions of ocaml.
Created attachment 19312 [details, diff]
Patch to change checking ocaml version
Originally, mldonkey checks for ocaml versions 3.06 and 3.07. This patch
changes that, so that mldonkey now checks for ocaml versions 3.06* and 3.07*,
allowing compilation with patched versions of ocaml which change the ocaml
version, like the latest bug-fix for ocaml-3.07 released by its development
team (after patching, the ocaml version becomes 3.07+2).
These are some bits I would change in the ebuild:
- >=dev-lang/ocaml-3.06*
+ >=dev-lang/ocaml-3.06
Just cosmetic, with '>=' the '*' is not needed.
If we pass to ./configure the option '--enable-ocamlver=3'
instead of guessing the right version of ocaml, we avoid troubles and we
don't need the patch anymore.
Installing the docs:
cd ${S}/docs
- dodoc *.txt *.tex
+ dodoc *.txt *.tex *.pdf
dohtml *.html
To include a new doc which is in 2.5.4 (I'm a perfectionist, I know ;)
Can we substitute the code which adds the 'p2p' user with a single line calling
'enewuser' (from eutils.eclass)? It's the Gentoo way!
I think in ${FILESDIR}/mldonkey it's better to change a line:
- cd ${HOME}/.mldonkey && /usr/bin/mlnet
+ cd ${HOME}/.mldonkey && exec /usr/bin/mlnet
It's more friendly with respect to Ctrl-C Ctrl-Z.
Bye!
*** Bug 28761 has been marked as a duplicate of this bug. *** added 2.5.4 with your tweaks :) |
