Bug 308569

Summary:	xfce-base/xfce4-panel-4.6* window decorations visible with >=dev-libs/glib-2.23.1
Product:	Gentoo Linux	Reporter:	Michal Kurgan <moloh>
Component:	New packages	Assignee:	XFCE Team <xfce>
Status:	RESOLVED FIXED
Severity:	normal	CC:	joshua.rich, mgorny
Priority:	High
Version:	autobuilds
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	309237
Attachments:	Removes window decorations from the xfce4 panel Ebuild applying the xfce4-panel patch

Description Michal Kurgan 2010-03-09 01:58:22 UTC

xfce-base/xfce4-panel-4.6* window decorations visible with >=dev-libs/glib-2.23.1

I am using gnome overlay and for some reason glib-2.23.4 is marked stable there, as result i did hit this bug.

Upstream references:
http://bugzilla.xfce.org/show_bug.cgi?id=6110
https://bugzilla.gnome.org/show_bug.cgi?id=557151

Comment 1 David Heavens 2010-03-09 11:22:41 UTC

Created attachment 222813 [details, diff]
Removes window decorations from the xfce4 panel

The patch submitted by Nick Schermer on http://bugzilla.xfce.org/show_bug.cgi?id=6110 as http://bugzilla.xfce.org/attachment.cgi?id=2759

Comment 2 David Heavens 2010-03-09 11:24:17 UTC

This patch worked for me using dev-libs/glib-2.23.4

Comment 3 David Heavens 2010-03-10 13:57:33 UTC

Created attachment 222981 [details]
Ebuild applying the xfce4-panel patch

should have also attached this file yesterday.

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2010-03-12 12:28:46 UTC

The patch is compatible with old glib/gtk+ ?

Comment 5 Michal Kurgan 2010-03-13 00:44:22 UTC

(In reply to comment #4)
> The patch is compatible with old glib/gtk+ ?

glib is safe, gtk+ looks safe.
If there is problem, then gtk+ docs are wrong.

Comment 6 Samuli Suominen (RETIRED) gentoo-dev

2010-03-20 11:33:40 UTC

+*xfce4-panel-4.6.2-r1 (20 Mar 2010)
+
+  20 Mar 2010; Samuli Suominen <ssuominen@gentoo.org>
+  +xfce4-panel-4.6.2-r1.ebuild, +files/xfce4-panel-4.6.2-glib-2.23.patch:
+  Fix glib >= 2.23 compability wrt #308569, thanks to Michal Kurgan and

Comment 7 Samuli Suominen (RETIRED) gentoo-dev

2010-03-20 11:34:30 UTC

(In reply to comment #5)
> (In reply to comment #4)
> > The patch is compatible with old glib/gtk+ ?
> 
> glib is safe, gtk+ looks safe.
> If there is problem, then gtk+ docs are wrong.
> 

And just to be sure, I've raised the glib dep to 2.20 and gtk+ to 2.12 (minimal versions available in portage) from previous 2.8 and 2.10

Comment 8 Michał Górny archtester

2010-03-20 13:11:16 UTC

(In reply to comment #4)
> The patch is compatible with old glib/gtk+ ?

I've tested it with glib-2.22.4 & gtk+-2.18.6, and it works fine.