Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 308331

Summary: app-cdr/sync2cd: Verify and potentially improve Python-related code
Product: Gentoo Linux Reporter: Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever>
Component: Current packagesAssignee: Daniel Black (RETIRED) <dragonheart>
Severity: normal CC: media-optical, remy
Priority: Highest    
Version: unspecified   
Hardware: All   
OS: All   
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 308257    
Attachments: Updated ebuild

Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-03-07 17:22:33 UTC
- If this package could support installation for multiple versions of Python,
  then please try to adjust the ebuilds to support it.
- Ensure that the ebuilds do not use deprecated functions or variables.
- Please check if Python 3 is supported by this package.
- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

Please see documentation [1] for more details.
Comment 1 Daniel Black (RETIRED) gentoo-dev 2010-07-18 05:02:28 UTC
notice sent for removal
Comment 2 Remy Blank 2010-07-19 12:59:15 UTC
(In reply to comment #1)
> notice sent for removal

I'm the author of sync2cd, and I'm a bit surprised that nobody has even tried to contact me about this. Also, the message "Abandoned upstream" in package.mask is not completely accurate: the program works fine as-is, I'm still using it regularly and I haven't received any improvement suggestions, so I'd rather say it's "stable".

Then again, I'm probably the only user, and I'm installing from my own overlay, so I wont argue against the removal :)
Comment 3 Daniel Black (RETIRED) gentoo-dev 2010-07-20 05:43:32 UTC
(In reply to comment #2)
> I'm the author of sync2cd, and I'm a bit surprised that nobody has even tried
> to contact me about this.
Ah - sorry Remy. Was rushing too much again.

Can you do some checks to make sure the code works python version 3 so I can make an ebuild that works for both?

Comment 4 Remy Blank 2010-07-20 08:00:54 UTC
Created attachment 239505 [details]
Updated ebuild
Comment 5 Remy Blank 2010-07-20 08:12:21 UTC
I have attached an updated ebuild taking into account the comments in the description. However:

 - The package doesn't work with Python 3.
 - Porting it to Python 3 will be quite a bit more involved than just running 2to3, as the archive format depends on Python string syntax, which has changed between 2 and 3 (yeah, I know, bad programming practice), and I don't have time to do it ATM.

For these reasons, the updated ebuild restricts installation to Python 2. I have tested it with 2.6.

But as I mentioned in comment #1, I'm probably the only user of the package, and I don't even know how it landed in portage in the first place, so feel free to drop it, I won't be offended. The only reason I chimed in was the "abandoned upstream" message, it's rather "in maintenance mode".
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-07-21 16:08:48 UTC
Please use patches in unidiff format.
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-04-06 17:38:01 UTC
Fixed in app-cdr/sync2cd-1.3.