| Summary: | app-cdr/burn-cd: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | Gentoo Optical Media project <media-optical> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | normal | CC: | idella4, openhs |
| Priority: | Highest | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 308257 | ||
| Attachments: |
ebuild patch
ebuild patch revised revised ebuild patch |
||
Created attachment 292263 [details, diff]
ebuild patch
Tested python 2.5 2.6 2.7 3.1 3.2
Again python 2.5 doesn't support. EAPI bump 3
Tested emerges, all aok.
Use PYTHON_DEPEND="2" or maybe PYTHON_DEPEND="2:2.6". Why do you think that this package doesn't work with Python 2.5? Such pkg_setup() is not needed. python_convert_shebangs() internally calls die(). Created attachment 292481 [details, diff]
ebuild patch revised
done
(In reply to comment #3) PYTHON_DEPEND still wrong. Created attachment 292589 [details, diff]
revised ebuild patch
ok, 3rd time lucky
I guess this should go to the tree because with Python 3 as default python interpreter burn-cd does not work:
-----------------------------------
# burn-cd
File "/usr/bin/burn-cd", line 162
sys.stderr.write( '[CONFIG WARNING] line %d: input "%s" is not a string\n' % (number,`obj`) )
^
SyntaxError: invalid syntax
-----------------------------------
Clearly the script is not compatible with Python 3 and shebangs are not converted:
# head -n 1 /usr/bin/burn-cd
#!/usr/bin/python -O
Tested on stable amd64 for both burn-cd versions: stable 1.7.4 and testing 1.8.0 with same results.
# eselect python list
Available Python interpreters:
[1] python2.7
[2] python3.3
[3] python3.4 *
This approach was changed by the -r1 python eclasses |
- If this package could support installation for multiple versions of Python, then please try to adjust the ebuilds to support it. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml