| Summary: | app-admin/kedpm: Verify and potentially improve Python-related code | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Arfrever Frehtes Taifersar Arahesis (RETIRED) <arfrever> |
| Component: | Current packages | Assignee: | Daniel Black (RETIRED) <dragonheart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bss, chutz+bugs.gentoo.org, felix.schuster |
| Priority: | Highest | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 308257 | ||
| Attachments: |
kedpm-0.4.0-r1.patch
kedpm-0.4.0-r1.patch |
||
same functionality as kwallet. No driving need to fix. gentoo-dev-announce coming soon. (In reply to comment #1) > same functionality as kwallet. No driving need to fix. gentoo-dev-announce > coming soon. The one feature I really like in kedpm are that it has a command line interface and does not need all of KDE (I am not a kde user anyway) which makes it my tool of choice. I am not going to complain but the "Performs same functionality as kwallet" is not correct. (In reply to comment #2) If you can provide and ebuild that meets the needs of this bug report I'll happily use it. As much as I like making users like yourself I'm a little time constrained to do it properly. Writing it of as a dated package was the easy way for me. Sorry about material in-correctness of kwallet comparisons. (In reply to comment #3) > If you can provide and ebuild that meets the needs of this bug report I'll > happily use it. > > As much as I like making users like yourself I'm a little time constrained to > do it properly. Writing it of as a dated package was the easy way for me. No worries. I will give it a try later this week. It's a little sad that nobody wants to take over maintenance of this package. Created attachment 239655 [details, diff]
kedpm-0.4.0-r1.patch
A patch that seems to do what is needed. kedpm does not work with Python 3, a quick look shows that is at least because it uses "print" with no parentheses around the parameters.
I can try to patch it up for Python 3 later on, but this should satisfy this bug for now.
(In reply to comment #5) EAPI="3" is recommended. PYTHON_DEPEND="2" should be set (before call to inherit()). distutils.eclass inherits python.eclass, so don't inherit python.eclass. python_execute_function() checks return status of function executed by python_execute_function(), so ' || die "tests failed"' isn't needed. Created attachment 239879 [details, diff] kedpm-0.4.0-r1.patch (In reply to comment #6) > (In reply to comment #5) > > EAPI="3" is recommended. > PYTHON_DEPEND="2" should be set (before call to inherit()). > distutils.eclass inherits python.eclass, so don't inherit python.eclass. > python_execute_function() checks return status of function executed by > python_execute_function(), so ' || die "tests failed"' isn't needed. Thanks for the feedback. PYTHON_DEPEND was a huge omission, sorry about that. I bumped the EAPI, and also removed the default unpacking of sources (that's in EAPI 2, right?). Got rid of the "die" in the tests and verified that it still dies if I remove the restrict on the version 3 ABI. So, here is the updated patch. Applies on the original ebuild. (In reply to comment #7) This patch seems to be correct. when there exists a patch, why this bug has wontfix status? (In reply to comment #9) > when there exists a patch, why this bug has wontfix status? A fair question, I also find this package very useful. In addition, package.mask claims "Abandoned upstream" which I don't think is accurate --- the website is quite old, but commits have happened on Sourceforge within the year. Does this package need a maintainer or something? Fixed in app-admin/kedpm-0.4.0-r1. This package isn't used as a library, so I haven't added support for installation for multiple Python ABIs. |
- If this package could support installation for multiple versions of Python, then please try to adjust the ebuilds to support it. - Ensure that the ebuilds do not use deprecated functions or variables. - Please check if Python 3 is supported by this package. - If this package does not support Python 3: - Specify dependency on Python 2. You can use PYTHON_DEPEND helper variable, which should be set before inheriting of python eclass. - If this package cannot support installation for multiple versions of Python, then set active version of Python using python_set_active_version(). - Ensure that shebangs in installed scripts specify correct version of Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you can use python_convert_shebangs() to convert shebangs. (Wrapper scripts generated by python_generate_wrapper_scripts() do not require any changes.) Please see documentation [1] for more details. [1] http://www.gentoo.org/proj/en/Python/developersguide.xml