Bug 307743

Summary:	cvs.eclass does not honour ESCM_OFFLINE
Product:	Gentoo Linux	Reporter:	Martin Väth <martin>
Component:	Eclasses	Assignee:	SpanKY <vapier>
Status:	RESOLVED FIXED
Severity:	enhancement
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	311101
Bug Blocks:
Attachments:	Treat CVS_OFFLINE/ESCM_OFFLINE analogously to the other scm eclasses

Description Martin Väth 2010-03-04 10:22:38 UTC

cvs.eclass is the only scm eclass which ignores ESCM_OFFLINE
(bzr.eclass, git.eclass, mercurial.eclass, subversion.eclass all do).

In addition, ECVS_OFFLINE has a slightly different syntax than the other
offline variables (EBZR_OFFLINE, EGIT_OFFLINE, EHG_OFFLINE, ESVN_OFFLINE):
While the others are active if they are just nonempty,
ECVS_OFFLINE only becomes active if it is "1".

Both issues can be solved simultaneously by modifying one line.

Comment 1 Martin Väth 2010-03-04 10:24:58 UTC

Created attachment 222021 [details, diff]
Treat CVS_OFFLINE/ESCM_OFFLINE analogously to the other scm eclasses

Comment 2 Wormo (RETIRED) gentoo-dev

2010-03-14 23:35:14 UTC

Thanks for your proposed patch -- assigning to the eclass maintainer.

Comment 3 SpanKY gentoo-dev

2010-08-21 18:21:13 UTC

should be all set now ... thanks

http://sources.gentoo.org/eclass/cvs.eclass?r1=1.71&r2=1.72