Bug 307501 – app-office/openoffice-3.2.0 fails to build ucb module with net-misc/neon supporting SSPI

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-02 16:02:08 UTC]

Compiling: ucb/source/ucp/webdav/NeonSession.cxx
In file included from /var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx:41:
/usr/include/neon/ne_locks.h:125: warning: 'int ne_lock(ne_session*, ne_lock*)' hides constructor for 'struct ne_lock'
/var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx: In function 'int NeonSession_NeonAuth(void*, const char*, const char*, int, char*, char*)':
/var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx:341: warning: suggest parentheses around '&&' within '||'
/var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx: In member function 'void webdav_ucp::NeonSession::Init()':
/var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx:845: error: invalid conversion from 'int (*)(void*, const char*, const char*, int, char*, char*)' to 'int (*)(void*, const char*, int, char*, char*)'
/var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx:845: error:   initializing argument 3 of 'void ne_add_server_auth(ne_session*, unsigned int, int (*)(void*, const char*, int, char*, char*), void*)'
/var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx:846: error: invalid conversion from 'int (*)(void*, const char*, const char*, int, char*, char*)' to 'int (*)(void*, const char*, int, char*, char*)'
/var/tmp/portage/app-office/openoffice-3.2.0/work/ooo/build/OOO320_m12/ucb/source/ucp/webdav/NeonSession.cxx:846: error:   initializing argument 3 of 'void ne_add_proxy_auth(ne_session*, unsigned int, int (*)(void*, const char*, int, char*, char*), void*)'
dmake:  Error code 1, while making '../../../unxlngx6.pro/slo/NeonSession.obj'

/usr/include/neon/ne_utils.h contains:
#define NE_FEATURE_SSPI (8) /* NTLM/Negotiate authentication protocol via SSPI */

[Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-04 18:26:13 UTC]

Created attachment 222069 [details, diff]
neon-remove-SSPI-support.diff

Neon upstream has merged SSPI support differently, than is assumed by OpenOffice.
SSPI support is available only on Windows, so some code can be safely removed.
This patch fixes the build failure.

[Comment 2 Hanno Zysik (geki) 2010-03-04 20:17:21 UTC]

Could be good to report upstream and refer to this. See:
http://lists.manyfish.co.uk/pipermail/neon-commits/2009-November/000834.html

The committer is Kai.Sommerfeld at Sun.COM.

Also adding this reference:
http://qa.openoffice.org/issues/show_bug.cgi?id=105738

I do not see it fixed on trunk; did I miss something?
http://svn.services.openoffice.org/opengrok/xref/Current%20%28trunk%29/ucb/source/ucp/webdav/NeonSession.cxx#325

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-08 18:47:22 UTC]

OpenOffice maintainers: I would like to commit this patch if you don't object.

[Comment 4 Andreas Proschofsky (RETIRED) 2010-03-09 12:42:34 UTC]

If you have actually tested it: Go ahead.

[Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-09 17:42:35 UTC]

Fixed.