Summary: | prpltwtr-0.4.1 - [new w/ ebuild] a twitter-plugin for net-im/pidgin | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | avx <idevelop> |
Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | net-im |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | sunrise suggested | ||
Package list: | Runtime testing required: | --- | |
Attachments: |
prpltwtr-0.4.1.ebuild
prpltwtr-0.4.1-respect-destdir.patch prpltwtr-0.4.1.ebuild prpltwtr-0.4.1-respect-destdir.patch |
Description
avx
2010-03-02 03:26:51 UTC
Created attachment 221731 [details]
prpltwtr-0.4.1.ebuild
Created attachment 221733 [details, diff]
prpltwtr-0.4.1-respect-destdir.patch
Thank you for your work Manu. I'd like to suggest to put this plugin into Sunrise overlay http://overlays.gentoo.org/proj/sunrise/ This way developers will better review this ebuild and more users could easily use it. While we are here, some comments on ebuild: 1. epatch should be in src_prepare(). 2. Why do you need DESTDIR=${D} in src_compile? I guess it's safe to drop it. 3. DESTDIR=${D} <- ${D} should be quoted here. 4. ! use gtk && \ sed '6i\IS_PIDGIN=0' global.mak && \ sed -i "s:Home Timeline:Timeline:g" twitter.c I think it's better to rewrite something like: if ! use gtk; then sed '6i\IS_PIDGIN=0' global.mak || die sed -i "s:Home Timeline:Timeline:g" twitter.c || die fi This way emerge aborts if sed fails. 5. prpltwtr-0.4.1-respect-destdir.patch - Makefile's should respect DESTDIR, not D, thus patch should contain $(DESTDIR) (and note round quotes, this is common convention to use them in such cases). (In reply to comment #3) > While we are here, some comments on ebuild: > [...] New ebuild/patch with working fixes follows. Thanks for your suggestions. > I'd like to suggest to put this plugin into Sunrise overlay. > This way developers will better review this ebuild and > more users could easily use it. To be honest, I guess I won't. Besides the fact that I hate overlays, I find the process to get an account to cumbersome, instead of encouraging people to help/post new stuff it's more of a burden to me and I don't like to support that. Sorry - but whoever wants to push it to sunrise, they may do so. Created attachment 221791 [details]
prpltwtr-0.4.1.ebuild
Created attachment 221793 [details, diff]
prpltwtr-0.4.1-respect-destdir.patch
prpltwtr-0.11.0 is now in the tree. Closing. |