Bug 306871

Summary:	x11-misc/gigolo-0.4.0 does not respect LDFLAGS
Product:	Gentoo Linux	Reporter:	Doktor Notor <notordoktor>
Component:	New packages	Assignee:	XFCE Team <xfce>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fauli
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331933
Attachments:	gigolo-0.4.0.ebuild.diff

Description Doktor Notor 2010-02-25 20:54:00 UTC

* QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/gigolo

No patch included, sorry but NFC about this waf thing.

Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester

2010-03-03 16:30:54 UTC

(In reply to comment #0)

> No patch included, sorry but NFC about this waf thing.

Me either really :) Does the ebuild for www-client/midori provide any inspiration/insights?

Comment 2 Doktor Notor 2010-03-03 16:44:41 UTC

(In reply to comment #1)
> Me either really :) Does the ebuild for www-client/midori provide any
> inspiration/insights?

Well, I'll have a look. Honestly, I've seen the huge binary blob in the waf file, blinked and ran away. *g*

Comment 3 Doktor Notor 2010-03-08 09:16:33 UTC

Created attachment 222641 [details, diff]
gigolo-0.4.0.ebuild.diff

Switched to autotools, problem solved. As an additional benefit, it actually respects LINGUAS now.

Comment 4 Doktor Notor 2010-03-08 09:17:52 UTC

Oh, a little leftover - actually multilib autotools is redundant now in inherit.

Comment 5 Christian Faulhammer (RETIRED) gentoo-dev

2010-04-13 07:56:33 UTC

(In reply to comment #1)
> (In reply to comment #0)
> 
> > No patch included, sorry but NFC about this waf thing.
> 
> Me either really :) Does the ebuild for www-client/midori provide any
> inspiration/insights?

 Jeremy, can we get this going?

Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester

2010-04-13 14:38:57 UTC

(In reply to comment #5)

>  Jeremy, can we get this going?

Low priority, does not block stablereq. Feel free to commit.

Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester

2010-05-12 21:07:41 UTC

+  12 May 2010; Jeremy Olexa <darkside@gentoo.org> +gigolo-0.4.0-r1.ebuild:
+  Switch to autotools for a cleaner ebuild. bug 306871 by Doktor Notor

I was abit nervous to change it on the -r0 version. Anyway, thanks.