Summary: | media-gfx/digikam-1.2.0: Image rotation is broken | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Kuhn Markus <k17031965> |
Component: | [OLD] KDE | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | binki, dilfridge, esigra, me, px79 |
Priority: | High | Keywords: | InOverlay |
Version: | unspecified | Flags: | tampakrap:
Bugday+
|
Hardware: | AMD64 | ||
OS: | Linux | ||
URL: | http://bugs.kde.org/show_bug.cgi?id=228483 | ||
Whiteboard: | [kde testing] | ||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 321613 | ||
Attachments: |
Untested patch porting to jpeg-8
ebuild which applies patch against kipi-plugins-1.2.0 patch which fixes libjpeg v8a issue |
Description
Kuhn Markus
2010-02-24 17:18:37 UTC
jpeg image? digikam-1.1.0/libs/jpegutils/ ships a internal copy of libjpeg-6b which would make it incompatible with system libjpeg-8, and break rotating. (In reply to comment #1) > jpeg image? > > digikam-1.1.0/libs/jpegutils/ ships a internal copy of libjpeg-6b which would > make it incompatible with system libjpeg-8, and break rotating. > Yes, can not rotate JPEG images, PNG images are rotated. My English is very bad, and I do not understand your proposal. What can I do to fix the error? (In reply to comment #1) > jpeg image? > > digikam-1.1.0/libs/jpegutils/ ships a internal copy of libjpeg-6b which would > make it incompatible with system libjpeg-8, and break rotating. > It's worse than that. This is some snippet of stuff from the old libjpeg, heavily edited and extended for digikam, _and_ bundled with the old _internal_ headers. Patching it out may be a job for upstream. :( Well, based on the information here, I've opened http://bugs.kde.org/show_bug.cgi?id=228483 Either they confirm it or not. ;-) Thanks a lot for this bug report (and the cause of it)! I almost despaired of it, since half of my photos seemed to be corrupt... As a workaround, I downgraded from media-libs/jpeg-8 to media-libs/jpeg-7 and now lossless JPEG rotation works again. How do you think about changing/adding the digikam-1.1.0.ebuild dependancy to "<media-libs/jpeg-8"? Just as workaround until the problem is fixed in digikam itself. In order to protect other gentoo users against this bug. Created attachment 221563 [details, diff]
Untested patch porting to jpeg-8
This is an untested patch (well it compiles and links) to get things running with jpeg-8.
Basically, I did a Bad Thing and just replaced the files from jpeg-6b with those from jpeg-8...
+*digikam-1.1.0-r1 (07 Mar 2010) + + 07 Mar 2010; Samuli Suominen <ssuominen@gentoo.org> + +digikam-1.1.0-r1.ebuild: + Update internal jpeg files wrt http://bugs.kde.org/show_bug.cgi?id=228483. Updated from here: http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/jpegutils/libjpeg-80/ Since upstream bug was fixed; closing this one fixed. In case you have more issues, you need to provide way more information. ;-) And also use kdelibs-4.4.1 (or above) because of this fix, http://bugs.kde.org/show_bug.cgi?id=224229 (In reply to comment #7) > Since upstream bug was fixed; closing this one fixed. In case you have more > issues, you need to provide way more information. ;-) I wrote in the package.keywords this: > = media-gfx/digikam-1.1.0-r1 > = media-libs/jpeg-8a: 0 and compiled Digikam thereafter. gentoo64 ~ $ eix media-libs/jpeg [I] media-libs/jpeg Available versions: (62) 6b-r9 (7) ~ 7-r1 (0) 8 (~) 8a Installed versions: 8a (19:24:56 08.03.2010) gentoo64 ~ $ eix media-gfx/digikam [I] media-gfx/digikam Available versions: (4) 1.1.0 (~) 1.1.0-r1 and mergte Digikam thereafter. The error still exists Digikam-1.1.0-r1 can not rotate JPEG files and Gwenview-4.3.5 do not save changes with JPEG files. I put a new one .kde4 directory, but that brought no improvement. > The error still exists Digikam-1.1.0-r1 can not rotate JPEG files and
> Gwenview-4.3.5 do not save changes with JPEG files.
> I put a new one .kde4 directory, but that brought no improvement.
Ho hum. I kind of feared that since the patch does not too much more than mine. When I've confirmed that I'll reopen the bug.
(In reply to comment #10) > > The error still exists Digikam-1.1.0-r1 can not rotate JPEG files and > > Gwenview-4.3.5 do not save changes with JPEG files. > > I put a new one .kde4 directory, but that brought no improvement. > > Ho hum. I kind of feared that since the patch does not too much more than mine. > When I've confirmed that I'll reopen the bug. > Some console output (stdout/err) when trying to rotate image would be nice. And possibly gdb output... It'd be nice to know what is going wrong and where instead of just everyone saying "it doesn't work" :) Not fixed in -r1. The patch makes no change at all. The only stderr output when clicking on the "rotate arrows" is digikam(15194)/KEXIV2 KExiv2Iface::KExiv2::getImageOrientation: Orientation => Exif.Image.Orientation => 1 (independent of arrow direction or image). Trying to find out more. Also not fixed in media-gfx/digikam-9999. Requested upstream to re-open bug. (In reply to comment #13) > Also not fixed in media-gfx/digikam-9999. > Requested upstream to re-open bug. I think digikam is not the problem (AFAIK should be fixed there) but kipi-plugins as digikam use them to rotate pics (except when import pics) As stated in http://bugs.kde.org/show_bug.cgi?id=228483 the issue has been fixed in svn of kipi-plugins in rev 1115335 (http://websvn.kde.org/?view=revision&revision=1115335) I created a patch which applies against kipi-plugins-1.2.0 and it seems it fixes the problem Created attachment 231937 [details]
ebuild which applies patch against kipi-plugins-1.2.0
Created attachment 231941 [details, diff]
patch which fixes libjpeg v8a issue
(In reply to comment #16) > Created an attachment (id=231941) [details] > patch which fixes libjpeg v8a issue > Thank you, fixed in overlay (digikam-1.2.0). Since digikam-1.2.0 is only in the overlay, I consider this issue resolved... Bug 311935 is the version bump request. (In reply to comment #18) > Since digikam-1.2.0 is only in the overlay, I consider this issue resolved... > Bug 311935 is the version bump request. > The bug is also in the version that's in tree... how about reading the comments in this bug? The issue is not resolved before it's in Portage. digikam-1.2.0-r2 in portage. Thanks to all involved! |