Bug 306059

Summary:	www-client/surf-0.3 default download directory patch
Product:	Gentoo Linux	Reporter:	Boney McCracker <brendlerjg>
Component:	Current packages	Assignee:	Jeroen Roovers (RETIRED) <jer>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	http://hg.suckless.org/surf/rev/620201658a0f
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	proposed: surf-0.3-download.diff

Description Boney McCracker 2010-02-20 14:09:01 UTC

Great application. Glad to see it in portage.

Problem: can't download files (making the browser rather useless in many use cases).  

a) config.def.h refers to ".surf/dl" where it should be ".surf/dl/" (I will attach a patch for this, taken from a change made to the developer's repository (see link) -- apparently this will be fixed in 0.4, but who knows when that will be released).  This seems to fix one problem (right-clicking to download now works).

If the maintainer sees fit, this patch could be added to the ebuild to make this a usable browser for people who want to use it before the next release is made available.

b) However, left-clicking a link to download something seems to create an empty file (of the appropriate name).  The work-around would be, I suppose, to remember to right-click such links and choose "download" from the menu.

Reproducible: Always

Comment 1 Boney McCracker 2010-02-20 14:14:07 UTC

Created attachment 220473 [details, diff]
proposed: surf-0.3-download.diff

This patch is taken directly from the ongoing 0.3 -> 0.4 development as documented at:
http://hg.suckless.org/surf/rev/620201658a0f

The maintainer may deem this a "won't fix" and wait for the 0.4 release, based on an expectation it will be soon.  However, if that's not the case, I think this patch makes the browser generally usable by enabling download of files (or at least, that appeared to be the case for me).

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2010-02-20 18:25:38 UTC

Thanks. I applied that in -r1.