Summary: | Stabilise =dev-vcs/cssc-1.2.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jeroen Roovers (RETIRED) <jer> |
Component: | Current packages | Assignee: | Jeroen Roovers (RETIRED) <jer> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | amd64 |
Priority: | High | Keywords: | STABLEREQ |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Jeroen Roovers (RETIRED)
2010-02-17 21:16:23 UTC
As per irc discussion. The ebuild didn't die on emake. I added the die where required so this bug can proceed. The diff: scarab@arcarius: cssc $ cvs diff cssc-1.2.0.ebuild Index: cssc-1.2.0.ebuild =================================================================== RCS file: /var/cvsroot/gentoo-x86/dev-util/cssc/cssc-1.2.0.ebuild,v retrieving revision 1.3 diff -u -b -B -r1.3 cssc-1.2.0.ebuild --- cssc-1.2.0.ebuild 31 Jan 2010 19:48:56 -0000 1.3 +++ cssc-1.2.0.ebuild 26 Feb 2010 11:58:47 -0000 @@ -22,9 +22,11 @@ } src_configure() { econf --enable-binary; } -src_compile() { emake all; } +src_compile() { + emake all || die "emake failed" +} src_install () { - emake DESTDIR="${D}" install || die - dodoc README NEWS ChangeLog AUTHORS + emake DESTDIR="${D}" install || die "emake install failed" + dodoc README NEWS ChangeLog AUTHORS || die "dodoc failed" } FEATURES="test" emerge cssc
fails in test area with following output:
>>> Test phase [check]: dev-util/cssc-1.2.0
make -j6 -s -j1 check
Making check in bsd
Making check in docs
Making check in testutils
Making check in auxfiles
Making check in sccs-cgi
Making check in tests
.: From and to directories are identical, hence no work to do!
Running test root.sh
r1...root.sh: Test could not be completed: Please do not run the suite as root
make[2]: *** [test-initial] Error 1
make[1]: *** [check-recursive] Error 1
make: *** [check] Error 2
* ERROR: dev-util/cssc-1.2.0 failed:
* Make check failed. See above for details.
x86 stable, tests passed for me tests fail also for me in the same way than Tomas Would this do? +src_test() { + if hasq userpriv ${FEATURES}; then + emake -j1 check || die "emake check failed" + else + ewarn "The test suite should not be run as root. Skipping..." + fi +} + Should do, tests pass with userpriv and fail without here. Marked stable on amd64. |