Bug 305659 – Stabilise =dev-vcs/cssc-1.2.0

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jeroen Roovers (RETIRED) 2010-02-17 21:16:23 UTC]

Please stabilise:
=dev-util/cssc-1.2.0

[Comment 1 Tomáš Chvátal (RETIRED) 2010-02-26 12:00:17 UTC]

As per irc discussion.
The ebuild didn't die on emake. I added the die where required so this bug can proceed.

The diff:
scarab@arcarius: cssc $ cvs diff cssc-1.2.0.ebuild
Index: cssc-1.2.0.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-util/cssc/cssc-1.2.0.ebuild,v
retrieving revision 1.3
diff -u -b -B -r1.3 cssc-1.2.0.ebuild
--- cssc-1.2.0.ebuild   31 Jan 2010 19:48:56 -0000      1.3
+++ cssc-1.2.0.ebuild   26 Feb 2010 11:58:47 -0000
@@ -22,9 +22,11 @@
 }

 src_configure() { econf --enable-binary; }
-src_compile() { emake all; }
+src_compile() {
+       emake all || die "emake failed"
+}

 src_install () {
-       emake DESTDIR="${D}" install || die
-       dodoc README NEWS ChangeLog AUTHORS
+       emake DESTDIR="${D}" install || die "emake install failed"
+       dodoc README NEWS ChangeLog AUTHORS || die "dodoc failed"
 }

[Comment 2 Tomáš Chvátal (RETIRED) 2010-02-26 12:07:41 UTC]

FEATURES="test" emerge cssc

fails in test area with following output:

>>> Test phase [check]: dev-util/cssc-1.2.0                                                                                                                                             
make -j6 -s -j1 check
Making check in bsd
Making check in docs
Making check in testutils
Making check in auxfiles
Making check in sccs-cgi
Making check in tests
.: From and to directories are identical, hence no work to do!
Running test root.sh
r1...root.sh: Test could not be completed:  Please do not run the suite as root
make[2]: *** [test-initial] Error 1
make[1]: *** [check-recursive] Error 1
make: *** [check] Error 2
 * ERROR: dev-util/cssc-1.2.0 failed:
 *   Make check failed. See above for details.

[Comment 3 Paweł Hajdan, Jr. (RETIRED) 2010-02-26 12:12:22 UTC]

x86 stable, tests passed for me

[Comment 4 Pacho Ramos 2010-05-26 17:53:14 UTC]

tests fail also for me in the same way than Tomas

[Comment 5 Jeroen Roovers (RETIRED) 2010-05-26 18:24:25 UTC]

Would this do?

+src_test() {
+       if hasq userpriv ${FEATURES}; then
+               emake -j1 check || die "emake check failed"
+       else
+               ewarn "The test suite should not be run as root. Skipping..."
+       fi
+}
+

[Comment 6 Christoph Mende (RETIRED) 2010-06-07 10:17:09 UTC]

Should do, tests pass with userpriv and fail without here. Marked stable on amd64.