Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 305557

Summary: dev-libs/suikyo tries to install missing documentation
Product: Gentoo Linux Reporter: Diego Elio Pettenò (RETIRED) <flameeyes>
Component: New packagesAssignee: CJK Team <cjk>
Status: RESOLVED FIXED    
Severity: QA CC: ruby, sebasu216
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: Build log
diff of suikyo ebuild

Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-02-17 14:04:11 UTC
This bug has been open because your package reported in the log that dodoc was called for non-existent, files. This is generally a lower-level mistake, but it's annoying as it fills with false positives the log of packages that might forget to die on doins failures.

Please do correct this. Thanks.

Diego, on behalf of the QA team
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-02-17 14:04:35 UTC
Created attachment 220023 [details]
Build log
Comment 2 sebasu216 2010-03-02 22:45:15 UTC
This might be solved by changing erubydoc in ruby.eclass. This function doesn't check for the existence of certain directories.

A suggestion:

*** /usr/portage/eclass/ruby.eclass     2009-10-03 10:36:09.000000000 +0200
--- /usr/local/portage/eclass/ruby.eclass       2010-03-02 23:35:56.520737638 +0100
***************
*** 183,190 ****
        [ -n "${rdfiles}" ] && doins ${rdfiles}
        rmdir "${D}"${rdbase} 2>/dev/null || true
        if [ -d doc -o -d docs ] ; then
!               dohtml -x html -r {doc,docs}/*
!               dohtml -r {doc,docs}/html/*
        else
                dohtml -r *
        fi
--- 183,192 ----
        [ -n "${rdfiles}" ] && doins ${rdfiles}
        rmdir "${D}"${rdbase} 2>/dev/null || true
        if [ -d doc -o -d docs ] ; then
!               [ -d doc ] && dohtml -x html -r doc/*
!               [ -d docs ] && dohtml -x html -r docs/*
!               [ -d doc/html ] && dohtml -r doc/html*
!               [ -d docs/html ] && dohtml -r docs/html/*
        else
                dohtml -r *
        fi
Comment 3 Hans de Graaff gentoo-dev Security 2010-03-04 08:03:02 UTC
ruby.eclass is going to be deprecated soon, so it would be useful to see if this issue can be solved by converting the ebuild to use ruby-ng instead.
Comment 4 sebasu216 2010-03-05 11:14:25 UTC
Created attachment 222157 [details, diff]
diff of suikyo ebuild

For the time being a little change in the ebuild can resolve the issue.
Attached is a diff.
Comment 5 MATSUU Takuto (RETIRED) gentoo-dev 2010-03-20 16:53:20 UTC
thanks for the patch. In this case, its better to use dodoc simple way.
http://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.html

in cvs now.