Bug 30511 – handling of return status of ebuild functions not consistent

• Product: Portage Development
• Status: RESOLVED FIXED

[Description SpanKY 2003-10-06 14:43:02 UTC]

older versions (at least if iirc, but not that it matters) checked the return status of all functions to make sure they were 0 ...

however it seems now that sometimes it is checked while other times it is not ...
pkg_setup will fail if return is not 0
src_unpack will work regardless of return
src_compile will work regardless of return

i dont think the ret status of a portage func should be considered ... if the ebuild is to die, it should call `die`, and that's it ...
i hit a case once where i had a '[ `use blah` ] && do stuff' at the end of a function and the ebuild would die when blah wasnt in USE ... thus by never checking ret status we safe guard against people (like me) who suck

[Comment 1 Nicholas Jones (RETIRED) 2003-12-24 12:16:31 UTC]

In cvs for 59_pre9

[Comment 2 SpanKY 2004-01-08 09:31:18 UTC]

seems that the latest changes have broken this ?

return statuses are checked now for prerm, postrm, preinst, and postinst

ive hit a bunch of ebuilds which just finish up with:
!!! FAILED <func>: 1

i thought we were going to let the developers handle their own calls to die()

[Comment 3 SpanKY 2004-01-08 17:22:33 UTC]

*** Bug 37585 has been marked as a duplicate of this bug. ***

[Comment 4 Robin Johnson 2004-01-10 17:11:36 UTC]

pkg_setup failing if return != 0 exists in .49-r20 and broken the mod_php stable ebuild for a while.

[Comment 5 Marius Mauch (RETIRED) 2004-02-08 17:55:05 UTC]

supposed to be fixed in 2.0.50 which is stable now. If this bug is not fixed please reopen.