| Summary: | x11-misc/fbpanel-5.6: locale issues | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Harald van Dijk (RETIRED) <truedfx> |
| Component: | Current packages | Assignee: | Desktop Misc. Team <desktop-misc> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aanatoly, arthapex, donmartio |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
ebuild applying patch
patch for above ebuild |
||
|
Description
Harald van Dijk (RETIRED)
2010-02-10 19:30:22 UTC
Can you attach an ebuild, please. The ebuild can be seen at http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-misc/fbpanel/fbpanel-5.6.ebuild?rev=1.1&view=markup But it is very basic. It uses our base eclass, which essentially just runs ./configure && make && make install As mentioned in the error message i added the following:
src_configure() {
local myconf="--endianess=LITTLE"
econf ${myconf}
}
to an overlay ebuild.
The value LITTLE i found somewhere else.
No it compiles and works. But i think this is'nt the right way.
I think this endianess value should be provided by the environment. But
i don't know what it realy means and where to set it right.
try 6.0 6.0 no longer calls endianess.sh, so that takes care of the first two problems. It still fails on #3 though. Created attachment 225237 [details]
ebuild applying patch
Created attachment 225239 [details, diff]
patch for above ebuild
(In reply to comment #5) > 6.0 no longer calls endianess.sh, so that takes care of the first two problems. > It still fails on #3 though. > try the attachments please. with LC_CTYPE=tr_TR.UTF-8 ./configure generates config.mk with wrong variable names - they all caps besides 'i' which is lower case, e.g PREFiX = /home/anatoly/.local/ EPREFiX = /home/anatoly/.local/ BiNDiR = /home/anatoly/.local//bin SBiNDiR = /home/anatoly/.local//sbin even with the above patch?? it should reset LC_CTYPE to C if defined I mean that's why unpatched configure does not work. BTW, gnu autoconf has this code in a its configure script # NLS nuisances. LC_ALL=C export LC_ALL LANGUAGE=C export LANGUAGE and it solves the problem as well. I'll commit it to fbpanel source (In reply to comment #11) > I mean that's why unpatched configure does not work. BTW, gnu autoconf has this > code in a its configure script > # NLS nuisances. > LC_ALL=C > export LC_ALL > LANGUAGE=C > export LANGUAGE > > and it solves the problem as well. I'll commit it to fbpanel source > oh, don't do that or you will break portability of fbpanel. use the patch attached here. only set these to C if already set. those must not be set unconditionally because not all systems understand e.g. LANG=C (notably SCO). and fixing LC_MESSAGES prevents solaris sh from translating var values in `set'! Thanks for pointing that. I've commited your patch + 25 Mar 2010; Samuli Suominen <ssuominen@gentoo.org> fbpanel-6.0.ebuild, + +files/fbpanel-6.0-configure-LANG.patch: + Reset language vars to C in ./configure wrt #304373 by Harald van Dijk. Thanks, it builds, installs and runs now. |