Bug 303395

Summary:	net-analyzer/flow-tools-0.68-r6 broken due to bad patch from bug #213788
Product:	Gentoo Linux	Reporter:	Mike Nerone <mike>
Component:	Current packages	Assignee:	Gentoo Netmon project <netmon>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	rush.ru
Priority:	High
Version:	10.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Mike Nerone 2010-02-03 22:50:37 UTC

Bug #213788 resulted in a new patch being applied to flow-export in the flow-tools ebuild with a revbump to net-analyzer/flow-tools-0.68-r6. I believe the patch was unnecessary and indeed breaks flow-export:

A. Looking at the code prior to the patch, db_tmp was the variable name containing the port number from the command line as a string. db_port then gets the port converted to an integer. Validating db_tmp, the string, was perfectly valid.

B. After the patch, the code is truly broken: the line "db_port = atoi(db_tmp);" remains, but the line where db_tmp is set before that is removed, so its value is uninitialized.

C. Further evidence: I'm running the original, unpatched code on an Ubuntu box and it works fine (inserting into MySQL, incidentally - haven't tested PostgreSQL, though we do plan to switch to it before going into production).

Full disclosure: I haven't actually tested what I'm saying on Gentoo, but just glancing at the code it seems inescapable.

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2010-02-03 23:17:12 UTC

Don't CC when you can't set the Assignee, please.

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2010-02-03 23:18:01 UTC


*** This bug has been marked as a duplicate of bug 213788 ***