Bug 303345

Summary:	app-benchmarks/bonnie++ doesn't build with gcc-4.3
Product:	Gentoo Linux	Reporter:	Doug Warner <doug>
Component:	New packages	Assignee:	benchmarks <benchmarks>
Status:	RESOLVED FIXED
Severity:	normal	CC:	email, jer, mmokrejs, webmaster
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log on amd64 Adds back the patch ${P}-missing_include.patch

Description Doug Warner 2010-02-03 15:20:38 UTC

bonnie++ doesn't build w/ gcc-3.4 due to missing headers.  See below for compile errors.

Reproducible: Always

Steps to Reproduce:




on_csv2html.cpp: In function 'void usage()':
bon_csv2html.cpp:76: error: 'exit' was not declared in this scope
x86_64-pc-linux-gnu-g++ -O2  -DNDEBUG -Wall -W -Wshadow -Wpointer-arith -Wwrite-strings -pedantic -ffor-scope   -c bon_file.cpp
bon_csv2html.cpp: In function 'void calc_vals()':
bon_csv2html.cpp:224: error: 'qsort' was not declared in this scope
bon_csv2html.cpp: In function 'void read_in(const char*)':
bon_csv2html.cpp:423: error: 'free' was not declared in this scope
make: *** [bon_csv2html.o] Error 1

Comment 1 Jeroen Roovers (RETIRED) gentoo-dev

2010-02-04 21:10:44 UTC

Confirmed. 1.96 is fine, though.

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2010-02-04 21:12:57 UTC

Oddly enough:

*bonnie++-1.94 (23 Nov 2008)

  23 Nov 2008; Patrick Lauer <patrick@gentoo.org>
  +files/bonnie++-1.94-64bit.patch,
  +files/bonnie++-1.94-missing_include.patch, +bonnie++-1.94.ebuild:
  Bump to 1.94

  02 May 2008; Tiziano Müller <dev-zero@gentoo.org>
  +files/bonnie++-1.93c-missing_include.patch, bonnie++-1.93c.ebuild:
  Added patch to fix compilation problems with gcc-4.3

Comment 3 Fernando (likewhoa) 2010-02-18 15:14:19 UTC

can confirm this with stable bonnie++

Comment 4 Fernando (likewhoa) 2010-02-18 15:14:46 UTC

Created attachment 220159 [details]
build.log on amd64

Comment 5 Michael Weissenbacher 2010-02-23 07:11:38 UTC

The ebuild is simply missing the bonnie++-1.93c-missing_include.patch which was already added at some point. I think it got lost when bonnie++-1.93c was added back to the tree:
  08 Nov 2009; Mark Loeser <halcy0n@gentoo.org> +bonnie++-1.93c.ebuild:
  Add back the only stable version of bonnie++

I'm adding a patch for the ebuild.

Comment 6 Michael Weissenbacher 2010-02-23 07:15:17 UTC

Created attachment 220797 [details, diff]
Adds back the patch ${P}-missing_include.patch

Compiles cleanly with GCC 4.3 on my box.

Comment 7 Martin Mokrejš 2010-03-03 00:07:43 UTC

Somebody please commit the fix. Just hit this issue with bonnie++-1.93c on amd64 whereas ~x86 picks up bonnie++-1.96 as of now.

Comment 8 Raúl Porcel (RETIRED) gentoo-dev

2010-03-06 16:24:31 UTC

Fixed, thanks.