Summary: | www-client/conkeror works with gentoo prefix on amd64-linux | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Chetan Reddy <chetanreddy> |
Component: | Prefix Support | Assignee: | Gentoo Prefix <prefix> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Prefix-aware ebuild for Conkeror |
Description
Chetan Reddy
2010-01-22 08:48:25 UTC
Does it use your system's xulrunner or the one from prefix? oops. i had created a symlink called gre.d in my home folder instead of *.*gre.d which was making conkeror use the system's xulrunner. when i 'fixed' this and made conkeror use gentoo prefix's xulrunner, it started segfaulting whenever i tried to load a site. the same happens with www-client/mozilla-firefox though (which is already in gentoo prefix). After a recent update to xulrunner, both conkeror and mozilla-firefox began to work on both my rhel4 and fc11 boxes. Reopening. The user probably needs to be informed to set the ~/.gre.d link to use gentoo prefix's etc/gre.d . (In reply to comment #3) > After a recent update to xulrunner, both conkeror and mozilla-firefox began to > work on both my rhel4 and fc11 boxes. Reopening. The user probably needs to be > informed to set the ~/.gre.d link to use gentoo prefix's etc/gre.d . As I maintain conkeror I would not like to see an ecopied ebuild in the Prefix overlay, but the work be done in the main tree. How can I test for a Prefix environment for an according elog message? use prefix? Another fix for this problem is to change usr/lib/conkeror/contrib/run-conkeror from if [[ -d "/etc/gre.d" ]]; then xr=$(check-gre /etc/gre.d 2>/dev/null) fi to if [[ -d "/path/to/gentoo/prefix/etc/gre.d" ]]; then xr=$(check-gre /path/to/gentoo/prefix/etc/gre.d 2>/dev/null) fi This way, the user doesn't have to know about .gre.d and can have both a system version and a gentoo prefix version of conkeror installed and using their respective xulrunners by default. (In reply to comment #5) > Another fix for this problem is to change > usr/lib/conkeror/contrib/run-conkeror > from > if [[ -d "/etc/gre.d" ]]; then > xr=$(check-gre /etc/gre.d 2>/dev/null) > fi > to > if [[ -d "/path/to/gentoo/prefix/etc/gre.d" ]]; then > xr=$(check-gre /path/to/gentoo/prefix/etc/gre.d 2>/dev/null) > fi > The proper method to do that is to inherit prefix.eclass, and use some method (patch, sed, etc.) to adjust the above from [[ -d "/etc/gre.d" ]] to [[ -d "@GENTOO_PORTAGE_EPREFIX@" ]], and then call eprefixify on the resulting file. That makes little sense to me. If you're sedding anyway, you can immediately put EPREFIX in there. If you come up with a patch to add @GENTOO_PORTAGE_EPREFIX@, then using eprefixify is the right thing. (In reply to comment #7) > That makes little sense to me. If you're sedding anyway, you can immediately > put EPREFIX in there. If you come up with a patch to add > @GENTOO_PORTAGE_EPREFIX@, then using eprefixify is the right thing. > That's what I meant, I just expressed myself poorly. As I am not able to test it properly in my Prefix environments, I will prepare a patched ebuild in the next couple of days (latest on monday) and attach it here. Chetan, can you test it then and report back? Created attachment 221061 [details]
Prefix-aware ebuild for Conkeror
Please try.
thanks fauli. it worked but only after i changed the sed command to sed -e "s:/etc/gre.d:\"${EPREFIX}/etc/gre.d\":g" -i "${D}${EPREFIX}"/usr/lib/conkeror/contrib/run-conkeror || die One weird thing i noticed is that ${D} ends with a slash, whereas the ebuild manual states that it is ${PORTAGE_BUILDDIR}/image without a slash. Not a problem here though, just something i noticed while debugging. Done, thanks for your test. |