Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 301322

Summary: sys-apps/portage-2.2_rc61 ebuild manifest syntax checking fails to catch syntax error
Product: Gentoo Linux Reporter: Mitch Harder <mmharder>
Component: New packagesAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: minor    
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Mitch Harder 2010-01-17 23:02:37 UTC
When writing a custom local ebuild with a USE flag dependancy, I found that syntax checking when I ran "ebuild (package.ebuild) manifest" missed an error that was later caught by running emerge on the same package.

For example, I used the following syntax in my ebuild:
DEPEND="${DEPEND}
        sources_standalone? !=sys-kernel/linux-sabayon-${PVR}"

The ebuild manifest command processes this syntax without error, however, an error is returned later when trying to emerge this ebuild.

This correct syntax should have included parenthesis around the package:
DEPEND="${DEPEND}
        sources_standalone? ( !=sys-kernel/linux-sabayon-${PVR} )"


Reproducible: Always

Steps to Reproduce:
1.  Edit an ebuild and insert USE flag dependancy syntax similar to the following:

DEPEND="${DEPEND}
        sources_standalone? !=sys-kernel/linux-sabayon-${PVR}"

2. Run "ebuild (package-name.ebuild) manifest"

Actual Results:  
The manifesting completes successfully.

Expected Results:  
The manifest operation should fail due to improper syntax.
Comment 1 Mitch Harder 2010-08-25 18:04:48 UTC
Confirmed this was fixed.
Comment 2 Zac Medico gentoo-dev 2010-08-25 18:13:40 UTC
(In reply to comment #1)
> Confirmed this was fixed.

In which version? We have stricter dependency handling in >=portage-2.2_rc68 so maybe that's what you are referring to.