Bug 300224 – emerge-delta-webrsync and eclean conflict in DISTDIR

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Sergei Trofimovich (RETIRED) 2010-01-08 21:51:43 UTC]

eclean is unaware of emerge-delta-webrsync's files in $DISTDIR:
portage-YYYYMMDD.*
Every time before I run 'eclean distfiles' I have to backup latest snapshow first, otherwise eclean will kill them.

Would be cool if:
1. eclean would have those files in exceptions by default(/etc/eclean/distfiles.exclude)
2. emerge-delta-webrsync would have separate variable (in make.conf or somewhere else, say, in /etc/conf.d/emerge-delta-webrsync) to store it's files

Thanks!

[Comment 1 Zac Medico 2012-08-14 02:27:55 UTC]

A regular expression like this in /etc/eclean/distfiles.exclude should do the trick:

portage-\d\d\d\d\d\d\d\d\.tar\.bz2(\.md5sum|\.umd5sum)?

@tools-portage:

Interested in having a pattern like this included in the default distfiles.exclude?

[Comment 2 Brian Dolbec (RETIRED) 2012-08-18 02:26:46 UTC]

Actually since you only need the latest, I could add a routine for processing those correctly too.  May as well clean out the old ones, just keep the latest.

[Comment 3 Zac Medico 2012-08-18 02:51:29 UTC]

(In reply to comment #2)
> Actually since you only need the latest, I could add a routine for
> processing those correctly too.  May as well clean out the old ones, just
> keep the latest.

Either way would be fine I guess, since emerge-delta-webrsync deletes the old ones automatically.

[Comment 4 Paul Varner (RETIRED) 2016-06-23 21:21:35 UTC]

(In reply to Zac Medico from comment #1)
> A regular expression like this in /etc/eclean/distfiles.exclude should do
> the trick:
> 
> portage-\d\d\d\d\d\d\d\d\.tar\.bz2(\.md5sum|\.umd5sum)?
> 
> @tools-portage:
> 
> Interested in having a pattern like this included in the default
> distfiles.exclude?

Looks like all that is needed for the regular expression is:

portage-\d\d\d\d\d\d\d\d\.tar\.bz2

I will add that to distfiles.exclude after a couple more days of testing, and let emerge-delta-webrsync handle the cleanup of older files

[Comment 5 Paul Varner (RETIRED) 2016-06-30 20:57:37 UTC]

I have added the 'portage-\d\d\d\d\d\d\d\d\.tar\.bz2' regular expression to the default distfiles.exclude

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=8507576f9a921f7b55f99e44fe9b33473e30d813

It can be tested with gentoolkit-9999

[Comment 6 Sergei Trofimovich (RETIRED) 2020-02-18 13:09:01 UTC]

Was released and stabilized a while ago:

$ git tag --contains=8507576f9a921f7b55f99e44fe9b33473e30d813
0.3.2
0.3.2-r1
gentoolkit-0.3.3
gentoolkit-0.4.0
gentoolkit-0.4.1
gentoolkit-0.4.2
gentoolkit-0.4.3
gentoolkit-0.4.4
gentoolkit-0.4.5
gentoolkit-0.4.6