Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 300145

Summary: Stable request for dev-db/sqlite-3.6.21
Product: Gentoo Linux Reporter: Petteri Räty (RETIRED) <betelgeuse>
Component: [OLD] LibraryAssignee: Petteri Räty (RETIRED) <betelgeuse>
Status: RESOLVED FIXED    
Severity: normal CC: arfrever, hppa, tomka
Priority: High Keywords: STABLEREQ
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 300674    
Bug Blocks: 297532    
Attachments: Test failures in x86 chroot

Description Petteri Räty (RETIRED) gentoo-dev 2010-01-08 10:33:19 UTC
This bug was filed via: http://gentoo.petteriraty.eu/stable.rss

  19 Dec 2009; Petteri Räty <betelgeuse@gentoo.org> sqlite-3.6.21.ebuild:
  Make building work without tcl installed using the amalgamation tarball
  from upstream. Fixes tests to work with -tcl. Thanks to Andrew
  <abrouwers@gmail.com>. Fixes bug #297113 and bug #297332.

  12 Dec 2009; Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org>
  sqlite-3.6.21.ebuild:
  Fix building and dependencies (bug #296245). SQLite's build system
  requires TCL at build time for so called amalgamation build. SQLite's
  upstream doesn't support non-amalgamation build.

*sqlite-3.6.21 (08 Dec 2009)

  08 Dec 2009; Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org>
  +sqlite-3.6.21.ebuild:
  Version bump.

Info for bug wranglers:
Herds: no-herd
Maintainers: arfrever@gentoo.org, betelgeuse@gentoo.org
Open bugs for dev-db/sqlite: 6
Open bugs for sqlite: 24
Keywords: ~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~sparc-fbsd ~x86 ~x86-fbsd

Because of how the ebuild is now done to build from two different tarballs. It's important you test these combinations:

 15     tcl? ( http://www.sqlite.org/${P}.tar.gz )
 16     !tcl? (
 17         test? ( http://www.sqlite.org/${P}.tar.gz )
 18         !test? ( http://www.sqlite.org/${PN}-amalgamation-${PV}.tar.gz )
 19     )

Also worth testing is making sure it works without tcl installed.
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2010-01-08 10:37:00 UTC
For most arches this is not a blocker for the security bug but for bug 297658 s390 and sh that had it still open that might be the case.
Comment 2 Andreas Schürch gentoo-dev 2010-01-08 11:54:21 UTC
> Also worth testing is making sure it works without tcl installed.

I think that should not happen then?!

Calculating dependencies... done!
[ebuild  N    ] dev-lang/tcl-8.5.7  USE="threads -debug" 4,319 kB
[ebuild  N    ] dev-db/sqlite-3.6.21  USE="fts3 readline test threadsafe -debug -doc -icu -soundex -tcl" 2,902 kB

Total: 2 packages (2 new), Size of downloads: 7,220 kB
Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2010-01-08 12:05:02 UTC
The ebuild pulls in Tcl because of USE=test, which gets enabled by FEATURES=test:

RDEPEND="icu? ( dev-libs/icu )
        readline? ( sys-libs/readline )
        tcl? ( dev-lang/tcl )"
DEPEND="${RDEPEND}
        test? ( dev-lang/tcl )
        doc? ( app-arch/unzip )"
Comment 4 Brent Baude (RETIRED) gentoo-dev 2010-01-10 13:40:38 UTC
ppc64 done
Comment 5 Thomas Kahle (RETIRED) gentoo-dev 2010-01-18 10:23:41 UTC
Created attachment 216790 [details]
Test failures in x86 chroot

Hi, I tested this in a stable x86 chroot with the "userpriv" feature set (required for FEATUES="test"). 
I get compile failes of the test-suite.
Comment 6 Thomas Kahle (RETIRED) gentoo-dev 2010-01-18 10:24:16 UTC
tcl ist installed. This is the emerge info of the chroot:

# emerge --info 
Portage 2.1.6.13 (default/linux/x86/10.0/desktop, gcc-4.3.4, glibc-2.10.1-r1, 2.6.32.2 i686)
=================================================================                           
System uname: Linux-2.6.32.2-i686-Intel-R-_Core-TM-2_Duo_CPU_L7500_@_1.60GHz-with-gentoo-1.12.13
Timestamp of tree: Mon, 18 Jan 2010 08:30:01 +0000                                              
ccache version 2.4 [disabled]                                                                   
app-shells/bash:     4.0_p35                                                                    
dev-lang/python:     2.6.4                                                                      
dev-util/ccache:     2.4-r7                                                                     
sys-apps/baselayout: 1.12.13                                                                    
sys-apps/sandbox:    1.6-r2                                                                     
sys-devel/autoconf:  2.63-r1                                                                    
sys-devel/automake:  1.9.6-r2, 1.10.2                                                           
sys-devel/binutils:  2.18-r3                                                                    
sys-devel/gcc-config: 1.4.1                                                                     
sys-devel/libtool:   2.2.6b                                                                     
virtual/os-headers:  2.6.27-r2                                                                  
ACCEPT_KEYWORDS="x86"                                                                           
CBUILD="i686-pc-linux-gnu"                                                                      
CFLAGS="-march=core2 -O2 -pipe"                                                                 
CHOST="i686-pc-linux-gnu"                                                                       
CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config"                                      
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"               
CXXFLAGS="-march=core2 -O2 -pipe"                                                                                                  
DISTDIR="/usr/portage/distfiles"                                                                                                   
FEATURES="collision-protect distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch userpriv"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa berkdb bluetooth branding bzip2 cairo cdr cli consolekit cracklib crypt cups cxx dbus dri dts dvd dvdr eds emboss encode evo fam firefox flac fortran gdbm gif gnome gpm gstreamer gtk hal iconv ipv6 jpeg kde ldap libnotify mad mikmod mng modules mp3 mp4 mpeg mudflap ncurses nls nptl nptlonly ogg opengl openmp pam pcre pdf perl png postgres ppds pppd python qt qt3support qt4 quicktime readline reflection sdl session spell spl ssl startup-notification svg sysfs tcpd thunar tiff tk truetype unicode usb vorbis win32codecs x264 x86 xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="intel"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 7 Thomas Kahle (RETIRED) gentoo-dev 2010-01-18 11:36:12 UTC
Ok, I think I understand this now.
USE="test" needs tcl to be configured to.
The deps are right but in the ebuild 

       # amalgamation doesn't have tcl
        econf \
                $(use_enable readline) \
                $(use_enable threadsafe) \
                $(use tcl && echo --enable-tcl) \
                $(use !tcl && use test && echo --disable-tcl)

needs to be updated such that use !tcl && use test enables tcl ..?

This is also the fix for bug #301058

Comment 8 Thomas Kahle (RETIRED) gentoo-dev 2010-01-20 12:57:36 UTC
> This is also the fix for bug #301058

I think this was a paste error. I mean bug #300674
Comment 9 Brent Baude (RETIRED) gentoo-dev 2010-01-22 20:34:49 UTC
ppc stable
Comment 10 Thomas Kahle (RETIRED) gentoo-dev 2010-02-01 22:53:45 UTC
I have been testing this version on my productive system for 2 weeks. Looks good so far. Somebody should look at the test failures in bug 300674. To me it seems like a one line change in the ebuild.
Comment 11 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-02 18:19:22 UTC
Petteri, any problems with the proposed changes?  Otherwise I am going to
commit them next week.
Comment 12 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-11 12:09:00 UTC
(In reply to comment #11)
> Petteri, any problems with the proposed changes?  Otherwise I am going to
> commit them next week.

 mduft fixed it for .22-r1, so we stable anyway.
Comment 13 Christian Faulhammer (RETIRED) gentoo-dev 2010-02-11 14:14:23 UTC
x86 stable
Comment 14 Raúl Porcel (RETIRED) gentoo-dev 2010-03-14 16:47:21 UTC
alpha/arm/ia64/s390/sh/sparc stable
Comment 15 Pacho Ramos gentoo-dev 2010-03-19 08:59:23 UTC
  07 Mar 2010; Markus Meier <maekke@gentoo.org> sqlite-3.6.22-r2.ebuild:
  amd64 stable, bug #307045
Comment 16 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-05-18 21:47:21 UTC
dev-db/sqlite-3.6.23.1 will be stabilized in bug #320467.