| Summary: | Version bump: app-emulation/vice-2.2 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | groepaz |
| Component: | New packages | Assignee: | Gentoo Games <games> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | Keywords: | EBUILD |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 258674 | ||
| Bug Blocks: | |||
| Attachments: |
VICE 2.2 ebuild
patch to 2.1 ebuild patch to 2.1 ebuild (removed arts) patch to 2.1 ebuild (removed arts rdep) |
||
|
Description
groepaz
2010-01-06 11:04:00 UTC
Created attachment 215371 [details]
VICE 2.2 ebuild
Have you seen bug 258674? Also, it's preferred to supply patches against current ebuilds instead of adding full ones. "Have you seen bug 258674?" have you seen who reported it? whats your point? "Also, it's preferred to supply patches against current ebuilds instead of adding full ones." and? if it will be ignored, just like the one in 258674, how would it make a difference anyway? (seriously, a patch for a file of that size ? *sigh* yeah sure, if *that* is what causes it not to be ignored, so be it.) Created attachment 215376 [details, diff]
patch to 2.1 ebuild
(In reply to comment #3) > "Have you seen bug 258674?" > have you seen who reported it? whats your point? My point is that whatever is fixed there, should be incorporated into the 2.2's ebuild to avoid duplicating the work. - --without-arts \ + $(use_with arts) \ And my point for having diff's to allow easy reviewing, to catch mistakes like above, kde-base/arts isn't in portage anymore. (In reply to comment #5) > My point is that whatever is fixed there, should be incorporated into the 2.2's > ebuild to avoid duplicating the work. ofcourse :) but yes, since i posted that one aswell, the respective changes have all been carried into this new one too :) > - --without-arts \ > + $(use_with arts) \ > > And my point for having diff's to allow easy reviewing, to catch mistakes like > above, kde-base/arts isn't in portage anymore. doh :) guess i am just to used to throwing such files into a graphical diff tool myself =P Created attachment 215397 [details, diff] patch to 2.1 ebuild (removed arts) - removed arts related stuff - readded bug #280976 related line(s) from original 2.1 ebuild Created attachment 215399 [details, diff]
patch to 2.1 ebuild (removed arts rdep)
- removed arts dependancy (sorry, missed it :))
groepaz, Thanks for the updated ebuild. Works great on amd64. Two comments: 1. The original ebuild you provided is slightly outdated, as it doesn't contain the fixes included in your newest diff (ie., arts is still there) 2. The most recent diff doesn't seem to apply against the vice-2.1 ebuild in my portage tree. Not sure if it's changed since you created your diff or what, but I ended up taking your 2.2 ebuild and manually adjusting it based on the diff file. Kind of a pain, but it worked. Would be even more helpful if you could provide an updated ebuild (or patch, if necessary, though I find that much less useful as a change in the source file breaks the diff) that's ready to go for anyone else that finds this thread. Thanks again. Actually, one more comment: the HOMEPAGE should probably be changed to http://vice-emu.sourceforge.net/. Given that the original page at viceteam.org has yet to be updated for the new release, it looks like the using the sourceforge page now. > 2. The most recent diff doesn't seem to apply against the vice-2.1 ebuild in my > portage tree. Not sure if it's changed since you created your diff or what, yes, look at the datestamp of the current ebuild. someone obviously decided that my fixes are useless and instead "fixed" the ebuild himself, leaving all the other bugs in there. > Would be even more helpful if you could provide an updated ebuild (or patch, if > necessary, seeing how this is handled, i am not sure if i even want to post another fix. seems rather pointless with maintainers that know it better than upstream, we will likely create our own overlay and be done with it. (In reply to comment #10) > Actually, one more comment: the HOMEPAGE should probably be changed to > http://vice-emu.sourceforge.net/. Given that the original page at viceteam.org > has yet to be updated for the new release, it looks like the using the > sourceforge page now. yes, sourceforge is the new home. the other will at some point redirect to it (the owner somehow is lost in action) vice-2.2 is in portage. |
